Fix/date validation

src/Donations/Endpoints/Endpoint.php

@@ -35,7 +35,8 @@ public function validateInt($value)
     public function validateDate($param, $request, $key)
     {
         // Check that date is valid, and formatted YYYY-MM-DD
-        list($year, $month, $day) = explode('-', $param);
+        if (substr_count($param, '-') !== 2) return false;
+        list($year, $month, $day) = array_map('intval', explode('-', $param));
         $valid = checkdate($month, $day, $year);
 
         // If checking end date, check that it is after start date

tests/Unit/Donations/Endpoints/TestListDonations.php

@@ -67,6 +67,44 @@ public function testShouldReturnListWithSameData()
         $this->assertSame($expectedItems, $response->data['items']);
     }
 
+    /**
+     * @unreleased
+     *
+     * @return void
+     * @throws Exception
+     */
+    public function testShouldFilterInvalidDateArgument_missingMonthDay()
+    {
+        $listDonation = give(ListDonations::class);
+        $key = 'start';
+        $value = '2020';
+
+        $mockRequest = $this->getMockRequest();
+        $mockRequest->set_param($key, $value);
+
+        $response = $listDonation->validateDate($value, $mockRequest, $key);
+        $this->assertFalse($response);
+    }
+
+    /**
+     * @unreleased
+     *
+     * @return void
+     * @throws Exception
+     */
+    public function testShouldFilterInvalidDateArgument_InvalidChar()
+    {
+        $listDonation = give(ListDonations::class);
+        $key = 'start';
+        $value = '2020-mar-02';
+
+        $mockRequest = $this->getMockRequest();
+        $mockRequest->set_param($key, $value);
+
+        $response = $listDonation->validateDate($value, $mockRequest, $key);
+        $this->assertFalse($response);
+    }
+
     /**
      *
      * @since 2.25.0