Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update form-builder-library to 1.7.1 #7750

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Feb 20, 2025

Resolves GIVE-2138
Reference: impress-org/form-builder-library#13

Description

Update package.json to better handle certain currencies with the CurrencyInput component .

Affects

Donation Levels in the form builder

Visuals

N/A

Testing Instructions

Create a VFB form.
Setting your Give currency to MXN peso from the currency settings.
Update your browser language to reflect generic Spanish.
Go to the build settings of your form -> update the donation level amounts and ensure that adding a number works properly. This includes adding or removing numbers, the UI of the input setting and the UI in the build preview.
Might be good to double check the frontend is not affected.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review February 20, 2025 03:18
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@jonwaldstein jonwaldstein merged commit 506f451 into develop Feb 20, 2025
20 checks passed
@jonwaldstein jonwaldstein deleted the chore/form-builder-library-1.7.1 branch February 20, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants