Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Remove cover video support #7751

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Refactor: Remove cover video support #7751

merged 2 commits into from
Feb 21, 2025

Conversation

pauloiankoski
Copy link
Contributor

@pauloiankoski pauloiankoski commented Feb 20, 2025 •
edited
Loading

Resolves GIVE-2127

Description

Our Uploader component is configured to filter the library to display only images. However, when uploading a video, it could still be selected. This Pull Request adds an additional check for the selected attachment type, displaying an alert if it is not an image.

Affects

Media Uploader

Visuals

CleanShot 2025-02-20 at 12 28 22

Testing Instructions

  1. Open a Campaign Settings page
  2. Upload a video (eg.: mp4 file) to the Cover setting
  3. Click the "Use this media" button
  4. Confirm that an alert is received and the video is not selected

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@pauloiankoski pauloiankoski changed the base branch from develop to epic/campaigns February 20, 2025 15:49
glaubersilva
glaubersilva approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauloiankoski Nice and simple solution. Ready to go!

rickalday
rickalday approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@jonwaldstein jonwaldstein merged commit 2d507f5 into epic/campaigns Feb 21, 2025
20 checks passed
@jonwaldstein jonwaldstein deleted the refactor/remove-cover-video-support branch February 21, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@glaubersilva glaubersilva glaubersilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pauloiankoski @rickalday @glaubersilva @jonwaldstein