Allow specifying the page size and filter for Backstage entities #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows you to customise the `limit` and `filter` parameters that we pass to the Backstage API. Fixes #60.
samstarling
commented
Feb 20, 2025
Comment on lines
-57
to
+59
| Load(ctx context.Context, logger kitlog.Logger) ([]*SourceEntry, error) | ||
| Load(ctx context.Context, logger kitlog.Logger, client *http.Client) ([]*SourceEntry, error) |
There was a problem hiding this comment.
This change to the interface makes it much easier to use a client with a mocked transport.
kelseymills
reviewed
Feb 20, 2025
Comment on lines
+64
to
+66
| if s.PageSize != 0 { | ||
| limit = s.PageSize | ||
| } |
There was a problem hiding this comment.
should we be validating this somewhere to check it's under a defined maximum?
There was a problem hiding this comment.
We could, but I don't know what the maximum is. This is going directly from wherever the catalog-importer runs to Backstage, so I don't think we need to introduce a maximum for performance reasons: I think you'd just get a 400 or similar from Backstage in the logs.
So I'm inclined to leave it I think!
kelseymills
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to customise the
limitandfilterparameters that we pass to the Backstage API. Fixes #60.