Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve Node 18 build issue with covid-data-monitor #1622

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

greatislander
Copy link
Member

@greatislander greatislander commented Jan 12, 2024

  • This pull request has been linted by running npm run lint without errors
  • This pull request has been tested by running npm run start and reviewing affected routes
  • This pull request has been built by running npm run build without errors
  • This isn't a duplicate of an existing pull request

Description

fs-extra is used in the inclusive-design/covid-data-monitor build script, but it's not a dependency, but rather a devDependency of covid-data-monitor. This means that the builds fail on Node 18, I think because of the way dependencies of dependencies are handled. This PR adds a (minimal) fix by running npm install fs-extra within the covid-data-monitor dependency before trying to build it.

Steps to test

  1. npm ci
  2. npm run build

Expected behavior: Build succeeds.

Additional information

Not applicable.

Related issues

Not applicable.

@greatislander greatislander added the bug Something isn't working label Jan 12, 2024
@greatislander greatislander self-assigned this Jan 12, 2024
@greatislander greatislander merged commit 6b02591 into inclusive-design:dev Jan 12, 2024
5 checks passed
@greatislander greatislander deleted the fix/node-18-build branch January 12, 2024 13:58
Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for wecount ready!

Name Link
🔨 Latest commit 7e843a4
🔍 Latest deploy log https://app.netlify.com/sites/wecount/deploys/65a143fc3a1a7f0007f7cc83
😎 Deploy Preview https://deploy-preview-1622--wecount.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 45
Accessibility: 95
Best Practices: 92
SEO: 91
PWA: 90
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant