fix: resolve Node 18 build issue with covid-data-monitor #1622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run lint
without errorsnpm run start
and reviewing affected routesnpm run build
without errorsDescription
fs-extra
is used in the inclusive-design/covid-data-monitor build script, but it's not a dependency, but rather a devDependency ofcovid-data-monitor
. This means that the builds fail on Node 18, I think because of the way dependencies of dependencies are handled. This PR adds a (minimal) fix by runningnpm install fs-extra
within thecovid-data-monitor
dependency before trying to build it.Steps to test
npm ci
npm run build
Expected behavior: Build succeeds.
Additional information
Not applicable.
Related issues
Not applicable.