Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve conference participant list #6489

Merged
merged 110 commits into from
Sep 22, 2024
Merged

Conversation

AjobK
Copy link
Member

@AjobK AjobK commented Aug 15, 2024

Closes #6440

Jinja participant list to React (Typescript) with QOL improvements

This PR replaces the old Jinja-based participant list with a new React Typescript based one. It is implemented in an existing Jinja template. The change includes QOL improvements, among other fixes that existed in the old table.

For an example, I would like to refer to https://hague.cern.ch/event/5/registrations/participants

(NEW) Participant Lists

Screenshot from 2024-08-15 13-48-01

(New) Participants Lists Merged

Screenshot from 2024-08-15 13-49-44

@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript deps labels Aug 15, 2024
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far just a few nitpicks ;) I'll have a look at the rest tomorrow

@AjobK AjobK requested a review from tomasr8 August 16, 2024 08:36
@AjobK
Copy link
Member Author

AjobK commented Aug 19, 2024

As discussed I will extend the scope a little bit more and also change some of the logic around the current ParticipantListAccordion component. This way we essentially reworked the whole page and we won't have to go back to it.

@github-actions github-actions bot removed dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript deps labels Aug 19, 2024
@AjobK AjobK force-pushed the qol-participants branch from 9a2195e to cc3c881 Compare August 19, 2024 15:13
@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript deps and removed dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript deps labels Aug 19, 2024
@AjobK AjobK force-pushed the qol-participants branch 2 times, most recently from c6821c6 to 12f55ea Compare August 22, 2024 12:26
@AjobK AjobK requested review from ThiefMaster and tomasr8 August 23, 2024 09:36
@AjobK AjobK force-pushed the qol-participants branch from 59a18f7 to ec4c68b Compare August 23, 2024 09:38
@AjobK AjobK force-pushed the qol-participants branch from 25db61e to 5c2fba6 Compare August 23, 2024 12:53
@tomasr8
Copy link
Member

tomasr8 commented Aug 23, 2024

One unfortunate thing that happens when we move jinja code to react is that we lose the translations. This is because we have separate PO files for python, js and react which are not shared when searching for translations (e.g. react code only searches in the react PO file).

Maybe at some point we could have a tool that can automatically move the translations from one PO file to another (or merge the PO files? 🤔 ). That would save a lot of time given that we have ~15 official languages and each one needs to be updated every time we make a change like this.

@AjobK
Copy link
Member Author

AjobK commented Aug 23, 2024

One unfortunate thing that happens when we move jinja code to react is that we lose the translations. This is because we have separate PO files for python, js and react which are not shared when searching for translations (e.g. react code only searches in the react PO file).

Maybe at some point we could have a tool that can automatically move the translations from one PO file to another (or merge the PO files? 🤔 ). That would save a lot of time given that we have ~15 official languages and each one needs to be updated every time we make a change like this.

I would not mind doing this at some point actually, although I'd have to know how the translations in both kind of correlate. Maybe it could be part of the bundling or something?

If you make an issue with the exact wishes and assign it to me I can get on it after my coming few tasks (or whenever).

@ThiefMaster ThiefMaster changed the title QOL Participants Improve conference participant list Sep 20, 2024
@ThiefMaster ThiefMaster merged commit ee848b0 into indico:master Sep 22, 2024
9 checks passed
@ThiefMaster ThiefMaster added this to the v3.3 milestone Sep 22, 2024
@AjobK AjobK deleted the qol-participants branch September 23, 2024 07:27
@AjobK
Copy link
Member Author

AjobK commented Sep 23, 2024

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve public conference participant list
4 participants