-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve conference participant list #6489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far just a few nitpicks ;) I'll have a look at the rest tomorrow
indico/modules/events/registration/client/js/components/ParticipantListAccordion.module.scss
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.module.scss
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
...co/modules/events/registration/client/js/components/RegistrationTagsEditableList.module.scss
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
As discussed I will extend the scope a little bit more and also change some of the logic around the current |
indico/modules/events/registration/client/js/components/ParticipantListAccordion.tsx
Outdated
Show resolved
Hide resolved
indico/modules/events/registration/templates/display/participant_list.html
Outdated
Show resolved
Hide resolved
9a2195e
to
cc3c881
Compare
...o/modules/events/registration/client/js/components/participant-list/ParticipantAccordion.tsx
Outdated
Show resolved
Hide resolved
c6821c6
to
12f55ea
Compare
59a18f7
to
ec4c68b
Compare
indico/modules/events/registration/client/js/components/participant-list/ParticipantTable.tsx
Outdated
Show resolved
Hide resolved
25db61e
to
5c2fba6
Compare
indico/modules/events/registration/client/js/components/participant-list/types.ts
Outdated
Show resolved
Hide resolved
One unfortunate thing that happens when we move jinja code to react is that we lose the translations. This is because we have separate PO files for python, js and react which are not shared when searching for translations (e.g. react code only searches in the react PO file). Maybe at some point we could have a tool that can automatically move the translations from one PO file to another (or merge the PO files? 🤔 ). That would save a lot of time given that we have ~15 official languages and each one needs to be updated every time we make a change like this. |
I would not mind doing this at some point actually, although I'd have to know how the translations in both kind of correlate. Maybe it could be part of the bundling or something? If you make an issue with the exact wishes and assign it to me I can get on it after my coming few tasks (or whenever). |
…ssue anyway which describes this desire
…e usage of enums and does not serve additional purpose here
e416e48
to
ba13518
Compare
b8fffc5
to
97fbd35
Compare
🥳 |
Closes #6440
Jinja participant list to React (Typescript) with QOL improvements
This PR replaces the old Jinja-based participant list with a new React Typescript based one. It is implemented in an existing Jinja template. The change includes QOL improvements, among other fixes that existed in the old table.
For an example, I would like to refer to https://hague.cern.ch/event/5/registrations/participants
(NEW) Participant Lists
(New) Participants Lists Merged