Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for different preference input types #32

Closed
wants to merge 5 commits into from

Conversation

nikolamajcen
Copy link
Member

@nikolamajcen nikolamajcen commented Feb 21, 2024

Based on #27, I've created a proposed solution without breaking backward compatibility for new input types.

Currently, there are only two types;

  • text
  • boolean

Which can be improved based on the changes @manuelvrhovac created in the PR mentioned. Also, additionally I added support for custom validators (two for now), which are type dependent and can be easily used on the item level.

@manuelvrhovac I would suggest checking this implementation (as this is an example of how we can simplify things), but with a new feature and idea you proposed. Let me know what you think.

Note
This is still WIP and should be discussed.

@nikolamajcen
Copy link
Member Author

Due to the SwiftUI re-write for v2.0.0 I believe we can close this one, correct @ZvonimirMedak? If needed, we can use similar approach and make new components for UIKit.

@nikolamajcen nikolamajcen changed the title [WIP] Support for different preference input types Proposal for different preference input types support Feb 21, 2025
@nikolamajcen nikolamajcen changed the title Proposal for different preference input types support Support for different preference input types Feb 21, 2025
@ZvonimirMedak
Copy link
Collaborator

Closing this one due to the SwiftUI rewrite, and the amount of changes that would be necessary for this PR. We will pick it up later on, and use the same approach but using SwiftUI

@ZvonimirMedak ZvonimirMedak deleted the feature/input-types branch February 25, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants