fix: Negative collection_offset Causes Multiple Executions #18178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a negative collection_offset value, the AlignedTicker could calculate a duration less than or equal to zero, causing the timer to fire immediately and repeatedly. This resulted in multiple executions and "Previous collection has not completed" debug messages. The fix ensures that when the calculated duration (time to next aligned interval plus offset) is non-positive, one full interval is added to schedule for the next valid tick time. This check is performed before adding jitter to maintain proper timing behavior. Also updated the sleep function to handle negative durations by returning immediately instead of creating a timer with a negative value. Fixes influxdata#18175 Signed-off-by: majiayu000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18175
Changes