Skip to content

Commit

Permalink
moved random func number from acctest
Browse files Browse the repository at this point in the history
  • Loading branch information
@unasra
unasra committed Sep 25, 2024
1 parent 6ca2c59 commit 4fe867e
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 18 deletions.
5 changes: 0 additions & 5 deletions internal/acctest/acctest.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ func RandomIP() string {
return fmt.Sprintf("%d.%d.%d.%d", rand.Intn(255), rand.Intn(255), rand.Intn(255), rand.Intn(255))
}

// RandomNumber Function to generate a random 12-digit number for cloud discovery Role ARN
func RandomNumber() string {
return fmt.Sprintf("%d", rand.Intn(999999999999))
}

func RandomName() string {
b := make([]byte, 6)
for i := range b {
Expand Down
32 changes: 19 additions & 13 deletions internal/service/clouddiscovery/providers_resource_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"errors"
"fmt"
"math/rand"
"net/http"
"testing"

Expand All @@ -18,7 +19,7 @@ func TestAccProvidersResource_basic(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test"
var v clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand Down Expand Up @@ -50,7 +51,7 @@ func TestAccProvidersResource_disappears(t *testing.T) {
resourceName := "bloxone_cloud_discovery_provider.test"
var v clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand All @@ -74,7 +75,7 @@ func TestAccProvidersResource_AccountPreference(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test_account_preference"
var v1, v2 clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand Down Expand Up @@ -108,7 +109,7 @@ func TestAccProvidersResource_AdditionalConfig(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test_additional_config"
var v clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand Down Expand Up @@ -144,7 +145,7 @@ func TestAccProvidersResource_CredentialPreference(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test_credential_preference"
var v clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand All @@ -169,7 +170,7 @@ func TestAccProvidersResource_Description(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test_description"
var v clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand Down Expand Up @@ -204,7 +205,7 @@ func TestAccProvidersResource_DesiredState(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test_desired_state"
var v clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand Down Expand Up @@ -239,7 +240,7 @@ func TestAccProvidersResource_Destinations(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test_destinations"
var v clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())
viewName := acctest.RandomNameWithPrefix("view")

resource.ParallelTest(t, resource.TestCase{
Expand Down Expand Up @@ -285,7 +286,7 @@ func TestAccProvidersResource_Name(t *testing.T) {
var v1, v2 clouddiscovery.DiscoveryConfig
name1 := acctest.RandomName()
name2 := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand Down Expand Up @@ -321,7 +322,7 @@ func TestAccProvidersResource_ProviderType(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test_provider_type"
var v1, v2, v3 clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
randNumber := acctest.RandomNumber()
randNumber := randomNumber()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randNumber)

resource.ParallelTest(t, resource.TestCase{
Expand Down Expand Up @@ -369,7 +370,7 @@ func TestAccProvidersResource_SourceConfigs(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test_source_configs"
var v1, v2 clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand Down Expand Up @@ -405,7 +406,7 @@ func TestAccProvidersResource_SyncInterval(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test_sync_interval"
var v clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand Down Expand Up @@ -438,7 +439,7 @@ func TestAccProvidersResource_Tags(t *testing.T) {
var resourceName = "bloxone_cloud_discovery_provider.test_tags"
var v clouddiscovery.DiscoveryConfig
name := acctest.RandomName()
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", acctest.RandomNumber())
configAccessId := fmt.Sprintf("arn:aws:iam::%s:role/infoblox_discovery", randomNumber())

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t) },
Expand Down Expand Up @@ -529,6 +530,11 @@ func testAccCheckProvidersDisappears(ctx context.Context, v *clouddiscovery.Disc
}
}

// RandomNumber Function to generate a random 12-digit number for cloud discovery Role ARN
func randomNumber() string {
return fmt.Sprintf("%d", rand.Intn(999999999999))
}

func testAccProvidersBasicConfig(name, providerType, accountPreference, accessIdType, credType, configAccessId string) string {
return fmt.Sprintf(`
resource "bloxone_cloud_discovery_provider" "test" {
Expand Down

0 comments on commit 4fe867e

Please sign in to comment.