Skip to content

Commit

Permalink
addressed review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Tejashree-RS committed Feb 14, 2025
1 parent dfa1466 commit 6cd67b0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 17 deletions.
6 changes: 3 additions & 3 deletions plugins/modules/ipam_federated_realm.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
DOCUMENTATION = r"""
---
module: ipam_federated_realm
short_description: Manage FederatedRealm
short_description: Manages the Federated Realm
description:
- Manage FederatedRealm
- The Federated Realm object is a unique set of federated blocks per realm.
version_added: 2.0.0
author: Infoblox Inc. (@infobloxopen)
options:
Expand Down Expand Up @@ -205,7 +205,7 @@ def payload_changed(self):
def find(self):
if self.params["id"] is not None:
try:
resp = FederatedRealmApi(self.client).read(self.params["id"], inherit="full")
resp = FederatedRealmApi(self.client).read(self.params["id"])
return resp.result
except NotFoundException as e:
if self.params["state"] == "absent":
Expand Down
17 changes: 3 additions & 14 deletions plugins/modules/ipam_federated_realm_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
DOCUMENTATION = r"""
---
module: ipam_federated_realm_info
short_description: Retrieves the FederatedRealm
short_description: Retrieves information about existing Federated Realm
description:
- Retrieves the FederatedRealm
- The Federated Realm object is a unique set of federated blocks per realm.
version_added: 2.0.0
author: Infoblox Inc. (@infobloxopen)
options:
Expand All @@ -31,16 +31,6 @@
- Filter query to filter objects
type: str
required: false
inherit:
description:
- Return inheritance information
type: str
required: false
choices:
- full
- partial
- none
default: full
tag_filters:
description:
- Filter dict to filter objects by tags
Expand Down Expand Up @@ -164,7 +154,7 @@ def __init__(self, *args, **kwargs):

def find_by_id(self):
try:
resp = FederatedRealmApi(self.client).read(self.params["id"], inherit="full")
resp = FederatedRealmApi(self.client).read(self.params["id"])
return [resp.result]
except NotFoundException as e:
return None
Expand Down Expand Up @@ -231,7 +221,6 @@ def main():
id=dict(type="str", required=False),
filters=dict(type="dict", required=False),
filter_query=dict(type="str", required=False),
inherit=dict(type="str", required=False, choices=["full", "partial", "none"], default="full"),
tag_filters=dict(type="dict", required=False),
tag_filter_query=dict(type="str", required=False),
)
Expand Down

0 comments on commit 6cd67b0

Please sign in to comment.