Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Juno version #254

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Update Juno version #254

merged 6 commits into from
Jun 10, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jun 10, 2024

10.06.2024

Update Juno from v21.0.0 to v22.0.0, version tagged as latest in https://github.com/CosmosContracts/juno/releases.

This PR also updates nixpkgs to the latest, with nix flake lock --update-input nixpkgs in order to have access to go v1.22.3. This requires the removal of go v1.20 since the attribute buildGo120Module is now missing.

This PR also replaced rnix-lsp from devshells.nix, as it is unmaintained, with oxalica nil https://github.com/oxalica/nil/tree/2023-08-09.

This PR also updates Apalache from v0.42.0 to v0.44.11.

@ljoss17 ljoss17 requested a review from romac June 10, 2024 07:48
Copy link
Collaborator

@JonathanLorimer JonathanLorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments, looks great tho!

@@ -12,7 +12,6 @@
devShells = {
default = pkgs.mkShell {
buildInputs = with pkgs; [
rnix-lsp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace with nil?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is part of nixpkgs it seems that simply adding nil worked, 1949823.
If I run nix develop #cosmos-shell and then nil --version I get: nil 2023-08-09

@@ -2,7 +2,7 @@
apalache-src,
pkgs,
}: let
version = "v0.42.0";
version = "v0.44.11 ";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, I wasn't able to get this to work!

@ljoss17 ljoss17 merged commit d7f2eac into main Jun 10, 2024
2 checks passed
@romac romac deleted the luca_joss/update-juno-to-v22 branch August 14, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants