Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ibc-core): port capability #1258

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Merge branch 'main' into rano/feat/module-management

4c0d95f
Select commit
Loading
Failed to load commit list.
Draft

feat(ibc-core): port capability #1258

Merge branch 'main' into rano/feat/module-management
4c0d95f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 18, 2024 in 1s

67.34% (+0.07%) compared to 8424f69

View this Pull Request on Codecov

67.34% (+0.07%) compared to 8424f69

Details

Codecov Report

Attention: Patch coverage is 81.48148% with 20 lines in your changes missing coverage. Please review.

Project coverage is 67.34%. Comparing base (8424f69) to head (4c0d95f).

Files Patch % Lines
...ics24-host/types/src/identifiers/capability_key.rs 28.57% 10 Missing ⚠️
ibc-testkit/src/testapp/ibc/core/types.rs 55.55% 4 Missing ⚠️
...rc/testapp/ibc/applications/nft_transfer/module.rs 0.00% 3 Missing ⚠️
...s/ics721-nft-transfer/src/handler/send_transfer.rs 0.00% 2 Missing ⚠️
ibc-testkit/src/testapp/ibc/core/core_ctx.rs 97.14% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
+ Coverage   67.27%   67.34%   +0.07%     
==========================================
  Files         235      236       +1     
  Lines       23538    23635      +97     
==========================================
+ Hits        15836    15918      +82     
- Misses       7702     7717      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov