Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: arm64 runner for linux and macos #111

Merged
merged 18 commits into from
Feb 4, 2025
Merged

ci: arm64 runner for linux and macos #111

merged 18 commits into from
Feb 4, 2025

Conversation

soareschen
Copy link
Collaborator

@soareschen soareschen commented Nov 12, 2024

Using the Ubuntu aarch64 runners from Github's public preview.

@rnbguy rnbguy force-pushed the soares/arm64-runner branch from 97d2ce4 to b97e860 Compare February 3, 2025 17:35
@rnbguy rnbguy changed the title Try adding ARM64 runner feat(ci): arm64 runner for linux and macos Feb 3, 2025
@rnbguy
Copy link
Member

rnbguy commented Feb 3, 2025

I managed to get all CI passed for ubuntu-24.04, ubuntu-24.04-arm and macros-14. But a few points:

  • I needed to rerun the e2e tests 2-3 times to get through the flaky failures.
  • I updated ubuntu-20.04 to ubuntu-24.04. Used ubuntu-22.04.
  • I can update macos-14 to macos-latest. Kept it.
  • We don't need macos.yml workflow file anymore. I can remove it. Renamed it.

@rnbguy rnbguy marked this pull request as ready for review February 3, 2025 20:48
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for investigating around. Just a question:

Couldn't we go with Ubuntu 20.04? Asking because I see it generally the more canonical version that most projects run on, thus I was wondering if we could stick with it for consistency. Otherwise looks good to me (including the above points).

@rnbguy
Copy link
Member

rnbguy commented Feb 4, 2025

Couldn't we go with Ubuntu 20.04?

I just picked up the latest one. I downgraded them to ubuntu-22.04 as ubuntu-20.04-arm is not available.

@rnbguy rnbguy force-pushed the soares/arm64-runner branch from d40a702 to a0c064a Compare February 4, 2025 08:18
@rnbguy rnbguy force-pushed the soares/arm64-runner branch from a44435b to 17f6128 Compare February 4, 2025 08:27
@rnbguy rnbguy force-pushed the soares/arm64-runner branch from df2173d to 04f1ff4 Compare February 4, 2025 13:03
@rnbguy rnbguy force-pushed the soares/arm64-runner branch from 04f1ff4 to 35d419a Compare February 4, 2025 13:59
@rnbguy rnbguy force-pushed the soares/arm64-runner branch from 57f64ba to a9af221 Compare February 4, 2025 17:50
@rnbguy rnbguy changed the title feat(ci): arm64 runner for linux and macos ci: arm64 runner for linux and macos Feb 4, 2025
@rnbguy rnbguy merged commit c12c631 into main Feb 4, 2025
7 checks passed
@rnbguy rnbguy deleted the soares/arm64-runner branch February 4, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants