-
Notifications
You must be signed in to change notification settings - Fork 22
feat: refactor app struct #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
8a770e6
3cb551b
d094f14
3e24e10
f10ff14
b2922ab
3399831
ed73fb3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,154 @@ | ||
package app | ||
|
||
import ( | ||
"cosmossdk.io/math" | ||
storetypes "cosmossdk.io/store/types" | ||
|
||
"github.com/cosmos/cosmos-sdk/runtime" | ||
sdk "github.com/cosmos/cosmos-sdk/types" | ||
"github.com/cosmos/cosmos-sdk/types/mempool" | ||
cosmosante "github.com/cosmos/cosmos-sdk/x/auth/ante" | ||
|
||
opchildlanes "github.com/initia-labs/OPinit/x/opchild/lanes" | ||
initialanes "github.com/initia-labs/initia/app/lanes" | ||
|
||
blockabci "github.com/skip-mev/block-sdk/v2/abci" | ||
blockchecktx "github.com/skip-mev/block-sdk/v2/abci/checktx" | ||
signer_extraction "github.com/skip-mev/block-sdk/v2/adapters/signer_extraction_adapter" | ||
"github.com/skip-mev/block-sdk/v2/block" | ||
blockbase "github.com/skip-mev/block-sdk/v2/block/base" | ||
mevlane "github.com/skip-mev/block-sdk/v2/lanes/mev" | ||
|
||
appante "github.com/initia-labs/miniwasm/app/ante" | ||
|
||
wasmtypes "github.com/CosmWasm/wasmd/x/wasm/types" | ||
) | ||
|
||
func setupBlockSDK( | ||
app *MinitiaApp, | ||
mempoolMaxTxs int, | ||
wasmConfig wasmtypes.WasmConfig, | ||
txCounterStoreKey *storetypes.KVStoreKey, | ||
) ( | ||
mempool.Mempool, | ||
sdk.AnteHandler, | ||
blockchecktx.CheckTx, | ||
sdk.PrepareProposalHandler, | ||
sdk.ProcessProposalHandler, | ||
error, | ||
) { | ||
|
||
// initialize and set the InitiaApp mempool. The current mempool will be the | ||
// x/auction module's mempool which will extract the top bid from the current block's auction | ||
// and insert the txs at the top of the block spots. | ||
signerExtractor := signer_extraction.NewDefaultAdapter() | ||
|
||
systemLane := initialanes.NewSystemLane(blockbase.LaneConfig{ | ||
Logger: app.Logger(), | ||
TxEncoder: app.txConfig.TxEncoder(), | ||
TxDecoder: app.txConfig.TxDecoder(), | ||
MaxBlockSpace: math.LegacyMustNewDecFromStr("0.01"), | ||
MaxTxs: 1, | ||
SignerExtractor: signerExtractor, | ||
}, opchildlanes.SystemLaneMatchHandler()) | ||
|
||
factory := mevlane.NewDefaultAuctionFactory(app.txConfig.TxDecoder(), signerExtractor) | ||
mevLane := mevlane.NewMEVLane(blockbase.LaneConfig{ | ||
Logger: app.Logger(), | ||
TxEncoder: app.txConfig.TxEncoder(), | ||
TxDecoder: app.txConfig.TxDecoder(), | ||
MaxBlockSpace: math.LegacyMustNewDecFromStr("0.09"), | ||
MaxTxs: 100, | ||
SignerExtractor: signerExtractor, | ||
}, factory, factory.MatchHandler()) | ||
|
||
freeLane := initialanes.NewFreeLane(blockbase.LaneConfig{ | ||
Logger: app.Logger(), | ||
TxEncoder: app.txConfig.TxEncoder(), | ||
TxDecoder: app.txConfig.TxDecoder(), | ||
MaxBlockSpace: math.LegacyMustNewDecFromStr("0.1"), | ||
MaxTxs: 100, | ||
SignerExtractor: signerExtractor, | ||
}, opchildlanes.NewFreeLaneMatchHandler(app.ac, app.OPChildKeeper).MatchHandler()) | ||
|
||
defaultLane := initialanes.NewDefaultLane(blockbase.LaneConfig{ | ||
Logger: app.Logger(), | ||
TxEncoder: app.txConfig.TxEncoder(), | ||
TxDecoder: app.txConfig.TxDecoder(), | ||
MaxBlockSpace: math.LegacyMustNewDecFromStr("0.8"), | ||
MaxTxs: mempoolMaxTxs, | ||
SignerExtractor: signerExtractor, | ||
}) | ||
|
||
lanes := []block.Lane{systemLane, mevLane, freeLane, defaultLane} | ||
mempool, err := block.NewLanedMempool(app.Logger(), lanes) | ||
if err != nil { | ||
return nil, nil, nil, nil, nil, err | ||
} | ||
|
||
anteHandler, err := appante.NewAnteHandler( | ||
appante.HandlerOptions{ | ||
HandlerOptions: cosmosante.HandlerOptions{ | ||
AccountKeeper: app.AccountKeeper, | ||
BankKeeper: app.BankKeeper, | ||
FeegrantKeeper: app.FeeGrantKeeper, | ||
SignModeHandler: app.txConfig.SignModeHandler(), | ||
}, | ||
IBCkeeper: app.IBCKeeper, | ||
Codec: app.appCodec, | ||
OPChildKeeper: app.OPChildKeeper, | ||
TxEncoder: app.txConfig.TxEncoder(), | ||
AuctionKeeper: *app.AuctionKeeper, | ||
MevLane: mevLane, | ||
FreeLane: freeLane, | ||
WasmKeeper: app.WasmKeeper, | ||
WasmConfig: &wasmConfig, | ||
TXCounterStoreService: runtime.NewKVStoreService(txCounterStoreKey), | ||
}, | ||
) | ||
if err != nil { | ||
return nil, nil, nil, nil, nil, err | ||
} | ||
|
||
// set ante handler to lanes | ||
opt := []blockbase.LaneOption{ | ||
blockbase.WithAnteHandler(anteHandler), | ||
} | ||
systemLane.(*blockbase.BaseLane).WithOptions( | ||
opt..., | ||
) | ||
mevLane.WithOptions( | ||
opt..., | ||
) | ||
freeLane.(*blockbase.BaseLane).WithOptions( | ||
opt..., | ||
) | ||
defaultLane.(*blockbase.BaseLane).WithOptions( | ||
opt..., | ||
) | ||
beer-1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
mevCheckTx := blockchecktx.NewMEVCheckTxHandler( | ||
app.BaseApp, | ||
app.txConfig.TxDecoder(), | ||
mevLane, | ||
anteHandler, | ||
app.BaseApp.CheckTx, | ||
) | ||
checkTxHandler := blockchecktx.NewMempoolParityCheckTx( | ||
app.Logger(), mempool, | ||
app.txConfig.TxDecoder(), mevCheckTx.CheckTx(), | ||
) | ||
checkTx := checkTxHandler.CheckTx() | ||
|
||
proposalHandler := blockabci.NewProposalHandler( | ||
app.Logger(), | ||
app.txConfig.TxDecoder(), | ||
app.txConfig.TxEncoder(), | ||
mempool, | ||
) | ||
|
||
prepareProposalHandler := proposalHandler.PrepareProposalHandler() | ||
processProposalHandler := proposalHandler.ProcessProposalHandler() | ||
|
||
return mempool, anteHandler, checkTx, prepareProposalHandler, processProposalHandler, nil | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
package app | ||
|
||
import ( | ||
storetypes "cosmossdk.io/store/types" | ||
|
||
dbm "github.com/cosmos/cosmos-db" | ||
servertypes "github.com/cosmos/cosmos-sdk/server/types" | ||
|
||
// kvindexer | ||
kvindexer "github.com/initia-labs/kvindexer" | ||
kvindexerconfig "github.com/initia-labs/kvindexer/config" | ||
blocksubmodule "github.com/initia-labs/kvindexer/submodules/block" | ||
tx "github.com/initia-labs/kvindexer/submodules/tx" | ||
nft "github.com/initia-labs/kvindexer/submodules/wasm-nft" | ||
pair "github.com/initia-labs/kvindexer/submodules/wasm-pair" | ||
kvindexermodule "github.com/initia-labs/kvindexer/x/kvindexer" | ||
kvindexerkeeper "github.com/initia-labs/kvindexer/x/kvindexer/keeper" | ||
) | ||
|
||
func setupIndexer( | ||
app *MinitiaApp, | ||
appOpts servertypes.AppOptions, | ||
kvindexerDB dbm.DB, | ||
) (*kvindexerkeeper.Keeper, *kvindexermodule.AppModuleBasic, *storetypes.StreamingManager, error) { | ||
// initialize the indexer keeper | ||
kvindexerConfig, err := kvindexerconfig.NewConfig(appOpts) | ||
if err != nil { | ||
return nil, nil, nil, err | ||
} | ||
Vritra4 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
kvIndexerKeeper := kvindexerkeeper.NewKeeper( | ||
app.appCodec, | ||
"wasm", | ||
kvindexerDB, | ||
kvindexerConfig, | ||
app.ac, | ||
app.vc, | ||
) | ||
|
||
smBlock, err := blocksubmodule.NewBlockSubmodule(app.appCodec, kvIndexerKeeper, app.OPChildKeeper) | ||
if err != nil { | ||
return nil, nil, nil, err | ||
} | ||
Vritra4 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
smTx, err := tx.NewTxSubmodule(app.appCodec, kvIndexerKeeper) | ||
if err != nil { | ||
return nil, nil, nil, err | ||
} | ||
Vritra4 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
smPair, err := pair.NewPairSubmodule(app.appCodec, kvIndexerKeeper, app.IBCKeeper.ChannelKeeper, app.TransferKeeper) | ||
if err != nil { | ||
return nil, nil, nil, err | ||
} | ||
Comment on lines
+47
to
+50
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add test coverage for error handling. The error handling for Do you want me to assist in generating the test cases for this error handling? ToolsGitHub Check: codecov/patch
|
||
smNft, err := nft.NewWasmNFTSubmodule(app.ac, app.appCodec, kvIndexerKeeper, app.WasmKeeper, smPair) | ||
if err != nil { | ||
return nil, nil, nil, err | ||
} | ||
Comment on lines
+51
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add test coverage for error handling. The error handling for Do you want me to assist in generating the test cases for this error handling? ToolsGitHub Check: codecov/patch
|
||
err = kvIndexerKeeper.RegisterSubmodules(smBlock, smTx, smPair, smNft) | ||
if err != nil { | ||
return nil, nil, nil, err | ||
} | ||
Comment on lines
+55
to
+58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add test coverage for error handling. The error handling for Do you want me to assist in generating the test cases for this error handling? ToolsGitHub Check: codecov/patch
|
||
|
||
// Add your implementation here | ||
|
||
kvIndexer, err := kvindexer.NewIndexer(app.GetBaseApp().Logger(), kvIndexerKeeper) | ||
if err != nil { | ||
return nil, nil, nil, err | ||
} else if kvIndexer == nil { | ||
return nil, nil, nil, nil | ||
} | ||
|
||
if err = kvIndexer.Validate(); err != nil { | ||
return nil, nil, nil, err | ||
} | ||
Vritra4 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
if err = kvIndexer.Prepare(nil); err != nil { | ||
return nil, nil, nil, err | ||
} | ||
Vritra4 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
if err = kvIndexerKeeper.Seal(); err != nil { | ||
return nil, nil, nil, err | ||
} | ||
Vritra4 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
if err = kvIndexer.Start(nil); err != nil { | ||
return nil, nil, nil, err | ||
} | ||
Vritra4 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
kvIndexerModule := kvindexermodule.NewAppModuleBasic(kvIndexerKeeper) | ||
streamingManager := storetypes.StreamingManager{ | ||
ABCIListeners: []storetypes.ABCIListener{kvIndexer}, | ||
StopNodeOnErr: true, | ||
} | ||
|
||
return kvIndexerKeeper, &kvIndexerModule, &streamingManager, nil | ||
Vritra4 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
Uh oh!
There was an error while loading. Please reload this page.