Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor app struct #60
feat: refactor app struct #60
Changes from 4 commits
8a770e6
3cb551b
d094f14
3e24e10
f10ff14
b2922ab
3399831
ed73fb3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Check warning on line 87 in app/blocksdk.go
app/blocksdk.go#L86-L87
Check warning on line 111 in app/blocksdk.go
app/blocksdk.go#L110-L111
Check warning on line 29 in app/indexer.go
app/indexer.go#L28-L29
Check warning on line 42 in app/indexer.go
app/indexer.go#L41-L42
Check warning on line 46 in app/indexer.go
app/indexer.go#L45-L46
Check warning on line 50 in app/indexer.go
app/indexer.go#L49-L50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test coverage for error handling.
The error handling for
pair.NewPairSubmodule
is not covered by tests.Do you want me to assist in generating the test cases for this error handling?
Tools
GitHub Check: codecov/patch
Check warning on line 54 in app/indexer.go
app/indexer.go#L53-L54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test coverage for error handling.
The error handling for
nft.NewWasmNFTSubmodule
is not covered by tests.Do you want me to assist in generating the test cases for this error handling?
Tools
GitHub Check: codecov/patch
Check warning on line 58 in app/indexer.go
app/indexer.go#L57-L58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test coverage for error handling.
The error handling for
kvIndexerKeeper.RegisterSubmodules
is not covered by tests.Do you want me to assist in generating the test cases for this error handling?
Tools
GitHub Check: codecov/patch
Check warning on line 64 in app/indexer.go
app/indexer.go#L64
Check warning on line 71 in app/indexer.go
app/indexer.go#L69-L71
Check warning on line 75 in app/indexer.go
app/indexer.go#L73-L75
Check warning on line 79 in app/indexer.go
app/indexer.go#L77-L79
Check warning on line 83 in app/indexer.go
app/indexer.go#L81-L83
Check warning on line 91 in app/indexer.go
app/indexer.go#L85-L91