handle empty output & executor & disabled batch submitter

[sh-cha]

Summary by CodeRabbit

• New Features

  • Introduced a new error type ErrKeyNotSet for better error handling.
  • Added EnableBatchSubmitter configuration option to control batch submitter activation.
  • New methods for address retrieval in the Celestia struct.
  • Added a no-operation data availability node (NoopDA) to enhance flexibility.

• Improvements

  • Enhanced error handling in various methods to prevent nil pointer dereferences and improve clarity.
  • Conditional checks added to ensure messages are only processed if valid.
  • Streamlined logic for address retrieval and message processing across multiple components.
  • Improved error handling for address retrieval in the GetAddress and GetAddressStr methods.

• Bug Fixes

  • Removed unnecessary error checks that could lead to panic conditions.

[coderabbitai]

Walkthrough

The changes encompass various modifications across multiple files, primarily focusing on enhancing error handling and refining control flow. Key alterations include the removal of error return types and nil checks, the introduction of new methods for address retrieval, and the implementation of conditional checks before appending messages to queues. Additionally, a new error type, ErrKeyNotSet, has been introduced to standardize error reporting related to missing keys. Overall, these changes aim to improve the robustness and clarity of the codebase.

Changes

Files	Change Summary
executor/batch/batch.go, executor/batch/handler.go, executor/child/withdraw.go, executor/executor.go, executor/host/batch.go, executor/host/deposit.go, executor/host/host.go	Modifications include the removal of unconditional checks for nil messages before appending to queues and improvements in error handling related to address retrieval and processing.
executor/celestia/celestia.go	Introduced error handling improvements, added new methods for address retrieval, and ensured nil checks for configurations to prevent dereferencing errors.
executor/types/config.go	Added a new boolean field EnableBatchSubmitter to control the activation of the batch submitter feature, along with updates to the default configuration method.
node/node.go	Simplified error handling in the GetBroadcaster method by updating the error returned when n.broadcaster is nil to a specific error type, types.ErrKeyNotSet.
provider/child/msgs.go, provider/child/query.go, provider/host/msgs.go, provider/host/query.go	Updated methods to improve error handling by replacing previous address retrieval methods with new ones that check for errors, returning appropriate values based on the success of the operation.
types/errors.go	Introduced a new error variable ErrKeyNotSet for standardized error reporting related to missing keys.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BatchSubmitter
    participant Host
    participant Child

    User->>BatchSubmitter: SetDANode(da)
    BatchSubmitter-->>User: Set DA Node (no error handling)

    User->>Host: Initiate Deposit
    Host->>Host: Check message validity
    alt Msg is valid
        Host->>Host: Append to Msg Queue
    else Msg is nil
        Host-->>User: No action taken
    end

    User->>Child: Handle Output
    Child->>Child: Check msg validity
    alt Msg is valid
        Child->>Child: Append to Msg Queue
    else Msg is nil
        Child-->>User: No action taken
    end

Loading

Poem

🐇 In the code where rabbits hop,
Changes made, we’ll never stop.
Errors caught, and messages clear,
With each fix, we spread good cheer!
Hopping through lines, we find our way,
Celebrating code, bright as day! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6f4ad9b and 7548765.

📒 Files selected for processing (16)

• executor/batch/batch.go (1 hunks)
• executor/batch/handler.go (2 hunks)
• executor/batch/noop_da.go (1 hunks)
• executor/celestia/celestia.go (4 hunks)
• executor/child/withdraw.go (1 hunks)
• executor/executor.go (2 hunks)
• executor/host/batch.go (1 hunks)
• executor/host/deposit.go (1 hunks)
• executor/host/host.go (1 hunks)
• executor/types/config.go (4 hunks)
• node/node.go (1 hunks)
• provider/child/msgs.go (3 hunks)
• provider/child/query.go (1 hunks)
• provider/host/msgs.go (3 hunks)
• provider/host/query.go (1 hunks)
• types/errors.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (16)

• executor/batch/batch.go
• executor/batch/handler.go
• executor/batch/noop_da.go
• executor/celestia/celestia.go
• executor/child/withdraw.go
• executor/executor.go
• executor/host/batch.go
• executor/host/deposit.go
• executor/host/host.go
• executor/types/config.go
• node/node.go
• provider/child/msgs.go
• provider/child/query.go
• provider/host/msgs.go
• provider/host/query.go
• types/errors.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[beer-1]

LGTM; btw can we just not create DA node when the config is disabled?