Revert "feat: add addresses to gas station in weave config"

[Benzbeeb]

Reverts #131

Summary by CodeRabbit

• Refactor
  • Streamlined gas station account management by switching to a mnemonic-based approach for generating addresses.
  • Enhanced the display of account balances and transaction feedback with updated formatting and clearer error messages.
• Tests
  • Expanded test coverage to ensure robust handling of funding failures and account validations, contributing to more reliable operations.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes transition gas station account management from a key-based approach to a mnemonic-based approach. Various components now retrieve the gas station mnemonic from configuration and use the crypto package to generate Bech32 addresses. The modifications span CLI balance display, configuration functions, account initialization, funding transactions, and tests with adjusted error handling and output formatting.

Changes

Files	Summary of Changes
cmd/gas_station.go, config/config.go, models/initialize.go, models/minitia/launch.go, models/relayer/init.go	Replaced key-based management with mnemonic-based flow. Removed gasStationKey and associated key recovery functions; added GetGasStationMnemonic; integrated crypto.MnemonicToBech32Address for address generation; updated configuration key names and error handling.
cmd/gas_station_integration_test.go, models/minitia/launch_test.go	Updated tests to use the new mnemonic configuration key; changed JSON key comparison and added a failure test for broadcast funding.
models/minitia/tx.go	Modified transaction methods to retrieve the gas station mnemonic, recover keys via cosmosutils.RecoverKeyFromMnemonic, adjust error messages, and update address formatting.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Config
    participant Crypto
    participant BalanceService
    User->>Config: Request gas station mnemonic
    Config-->>User: Return mnemonic
    User->>Crypto: Convert mnemonic to Bech32 addresses (MnemonicToBech32Address)
    Crypto-->>User: Return initiaGasStationAddress & celestiaGasStationAddress
    User->>BalanceService: Query balance using generated addresses
    BalanceService-->>User: Return gas station balance

Loading

sequenceDiagram
    participant Trigger
    participant Config
    participant Crypto
    participant TxService
    Trigger->>Config: Request gas station mnemonic
    Config-->>Trigger: Return mnemonic
    Trigger->>Crypto: Recover key from mnemonic (RecoverKeyFromMnemonic)
    Crypto-->>Trigger: Return gas station key
    Trigger->>TxService: Sign and broadcast transaction using gas station key
    TxService-->>Trigger: Return transaction result

Loading

Possibly related PRs

• Ability to add gas station account in rollup genesis #14: Addresses changes in gas station mnemonic handling in models/minitia/launch.go with updated address generation.
• feat: revamp mnemonic and key file logic #123: Involves the shift from gas station keys to mnemonics in configuration and account management.
• Add unit test for relayer  #67: Updates the gas station mnemonic usage and crypto integration in the relayer initialization process.

Suggested reviewers

• traviolus
• WasinWatt

Poem

I'm a rabbit with a happy hop,
Coding changes made my heart go pop.
Keys are gone, mnemonics are in sight,
Crypto magic turning bytes to light.
With a twitch of my nose, I cheer the new flow,
Hop, hop—our gas station now glows!
🐰🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4d8c96 and f047f6e.

📒 Files selected for processing (8)

• cmd/gas_station.go (3 hunks)
• cmd/gas_station_integration_test.go (1 hunks)
• config/config.go (1 hunks)
• models/initialize.go (1 hunks)
• models/minitia/launch.go (7 hunks)
• models/minitia/launch_test.go (2 hunks)
• models/minitia/tx.go (6 hunks)
• models/relayer/init.go (11 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.