Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/app/models/interaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ class InteractionModel(SQLModel):
learner_id: int
item_id: int
kind: str
timestamp: datetime
created_at: datetime
2 changes: 1 addition & 1 deletion backend/app/routers/interactions.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def filter_by_max_item_id(
) -> list[InteractionLog]:
if max_item_id is None:
return interactions
return [i for i in interactions if i.item_id < max_item_id]
return [i for i in interactions if i.item_id <= max_item_id]


@router.get("/", response_model=list[InteractionModel])
Expand Down
33 changes: 33 additions & 0 deletions backend/tests/e2e/test_interactions.py
Original file line number Diff line number Diff line change
@@ -1 +1,34 @@
"""End-to-end tests for the GET /interactions endpoint."""

import pytest

BASE_URL = "http://localhost:5050" # Default, will be overridden by fixture


def test_get_interactions_returns_200(client) -> None:
"""Test 1: GET /interactions/ returns HTTP status code 200."""
response = client.get("/interactions/")
assert response.status_code == 200


def test_get_interactions_response_items_have_expected_fields(client) -> None:
"""Test 2: GET /interactions/ response items contain the expected fields."""
response = client.get("/interactions/")
data = response.json()
assert isinstance(data, list)
if len(data) > 0:
item = data[0]
assert "id" in item
assert "item_id" in item
assert "created_at" in item


def test_get_interactions_filter_includes_boundary(client) -> None:
"""Test 3: GET /interactions/?max_item_id=1 returns items with item_id <= 1."""
response = client.get("/interactions/", params={"max_item_id": 1})
assert response.status_code == 200
data = response.json()
assert isinstance(data, list)
assert len(data) > 0 # Should return non-empty list
for item in data:
assert item["item_id"] <= 1
7 changes: 7 additions & 0 deletions backend/tests/unit/test_interactions.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,10 @@ def test_filter_returns_interactions_below_max() -> None:
result = filter_by_max_item_id(interactions=interactions, max_item_id=2)
assert len(result) == 1
assert result[0].id == 1


def test_filter_includes_interaction_at_boundary() -> None:
"""Test that interactions with item_id equal to max_item_id are included."""
interactions = [_make_log(1, 1, 1), _make_log(2, 1, 2)]
result = filter_by_max_item_id(interactions=interactions, max_item_id=2)
assert len(result) == 2
Loading