[LW-10152] Setup preact webpack #1204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanessaPC
force-pushed
the
feat/lw-10152-setup-preact-webpack
branch
from
8423658 to
1b218d9
Compare
VanessaPC
changed the title
VanessaPC
force-pushed
the
feat/lw-10152-setup-preact-webpack
branch
from
6f6eefa to
6f5b46a
Compare
VanessaPC
force-pushed
the
feat/lw-10152-setup-preact-webpack
branch
from
6f5b46a to
4c00a6f
Compare
VanessaPC
force-pushed
the
feat/lw-10152-setup-preact-webpack
branch
4 times, most recently
from
e353038 to
aa1e0ed
Compare
VanessaPC
force-pushed
the
feat/lw-10152-setup-preact-webpack
branch
from
aa1e0ed to
8bfc274
Compare
| @@ -0,0 +1,53 @@ | |||
| { | |||
| "name": "@cardano-sdk/dapp-connector-preact", | |||
There was a problem hiding this comment.
it seems like there are 4 (or even 8?) spaces intentation here, lets change it to our default of 2?
|
|
||
|
|
||
| .home { | ||
| margin: 0 auto; |
There was a problem hiding this comment.
lets change it to 2 spaces intentation
| test: /\.(js|ts|tsx)$/, | ||
| use: [ | ||
| { | ||
| loader: 'babel-loader', |
There was a problem hiding this comment.
Let's replace Babel with https://swc.rs/ like we did in Lace 🙏
DominikGuzei
approved these changes
Apr 10, 2024
lucas-barros
approved these changes
Apr 10, 2024
| import './logs.css'; | ||
|
|
||
| export const Logs = () => { | ||
| const [storeState, setStoreState] = useState<Store>(connectorStore.initialState); |
There was a problem hiding this comment.
I would make this into a hook to be used in other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Set up Preact and match the previous functionality in the POC.
Proposed Solution
Set up Preact and substitute Vite with Webpack due to issues with
libsodium-wrapperpackage.Important Changes Introduced