-
Notifications
You must be signed in to change notification settings - Fork 63
[LW-8192] chore: adjust E2E for macOS (master
)
#1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
master
master
master
)
|
Note: I encountered an issue with projectors in E2E tests, on both macOS and Linux, reproducible on master, reported here.
Edit: fixed in #1208 |
e155777
to
1ace399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @michalrus! 🏆
Context
LW-8192
A continuation of #1171, this time tweaking the
local-network
container (and a few other things to make it work on macOS).This PR is for
master
, aconway-era
one is #1206.Again, underlying changes are in the
ogmios-tracker
repository.Testing
Proposed Solution
n/a
Important Changes Introduced
I removed sharing of the
node-sp1.sock
UNIX domain socket with the host machine. It doesn’t work on macOS (a different kernel), and doesn’t seem used from what I saw in the repository.If anyone really needs it, could they maybe consider
docker exec …
to runcardano-cli
etc.?