-
Notifications
You must be signed in to change notification settings - Fork 63
[LW-10266] Upgrade Axios version to 0.28.0 #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
4c5b536
to
c989e28
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still good, just a minor note.
packages/cardano-services/test/Handle/HandleHttpService.test.ts
Outdated
Show resolved
Hide resolved
BREAKING CHANGE: upgrade cardano-services, cardano-services-client, e2e and util-dev packages to use version 0.28.0 of Axios
2c72694
to
59fcd06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent work @VanessaPC
Upgrade the following packages in the cardano-js-sdk to use the latest version of Axios (0.28.0.
Packages affected:
cardano-services
,cardano-services-client
,e2e
andutil-dev
.Context
Lace wants to upgrade to use the latest of Axios and it's blocked because types changes in this dependency won't allow.
Proposed Solution
Important Changes Introduced
cardano-services
,cardano-services-client
,e2e
andutil-dev
now use Axios 0.28.0 .