Skip to content

feat(wallet): input resolver dependency is now composed with context input resolver #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/wallet/src/Wallets/BaseWallet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,14 @@ import {
TransactionsTracker,
UtxoTracker,
WalletUtil,
combineInputResolvers,
createAddressTracker,
createAssetsTracker,
createBalanceTracker,
createDRepRegistrationTracker,
createDelegationTracker,
createHandlesTracker,
createInputResolver,
createProviderStatusTracker,
createSimpleConnectionStatusTracker,
createTransactionReemitter,
Expand Down Expand Up @@ -248,6 +250,7 @@ const getDRepKeyHash = async (dRepKey: Ed25519PublicKeyHex | undefined) =>
dRepKey ? (await Ed25519PublicKey.fromHex(dRepKey).hash()).hex() : undefined;

export class BaseWallet implements ObservableWallet {
#inputResolver: Cardano.InputResolver | undefined;
#inputSelector: InputSelector;
#logger: Logger;
#tip$: TipTracker;
Expand Down Expand Up @@ -630,6 +633,11 @@ export class BaseWallet implements ObservableWallet {
})
};

if (inputResolver) {
this.#inputResolver = combineInputResolvers(createInputResolver(this), inputResolver);
this.util.resolveInput = this.#inputResolver?.resolveInput.bind(this.#inputResolver);
}

this.#logger.debug('Created');
}

Expand Down
36 changes: 36 additions & 0 deletions packages/wallet/test/PersonalWallet/methods.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,42 @@ describe('BaseWallet methods', () => {
expect(result).toEqual(output);
expect(inputResolver.resolveInput).toBeCalledTimes(1);
});

it('resolves using wallet context before using given input resolver', async () => {
const output = {
address: Cardano.PaymentAddress(
'addr_test1qpu5vlrf4xkxv2qpwngf6cjhtw542ayty80v8dyr49rf5ewvxwdrt70qlcpeeagscasafhffqsxy36t90ldv06wqrk2qum8x5w'
),
value: { coins: 997n }
};

const givenInputResolver = { resolveInput: jest.fn().mockResolvedValue(output) };

const walletWithInputResolver = createPersonalWallet(
{ name: 'Test Wallet' },
{
addressDiscovery,
assetProvider,
bip32Account,
chainHistoryProvider,
drepProvider,
handleProvider,
inputResolver: givenInputResolver,
logger,
networkInfoProvider,
rewardsProvider,
stakePoolProvider,
txSubmitProvider,
utxoProvider,
witnesser
}
);

const utxoSet = await firstValueFrom(walletWithInputResolver.utxo.available$);
const result = await walletWithInputResolver.util.resolveInput(utxoSet[0][0]);
expect(result).toEqual(utxoSet[0][1]);
expect(givenInputResolver.resolveInput).not.toHaveBeenCalled();
});
});
});

Expand Down
Loading