feat!: fee calculation now takes into account reference script size #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelCastilloB
force-pushed
the
feat/lw-12066-fee-calculation-for-spending-refer-script
branch
from
baad60d to
abf7808
Compare
BREAKING CHANGE: minFee now takes resolvedInputs and ProtocolParametersForInputSelection as arguments
AngelCastilloB
force-pushed
the
feat/lw-12066-fee-calculation-for-spending-refer-script
branch
from
abf7808 to
33527d5
Compare
AngelCastilloB
deleted the
feat/lw-12066-fee-calculation-for-spending-refer-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our fee calculation algorithm currently doesn't take into account script ref byte sizes. This PR makes a few changes to the fee calculation algorithm to include ref script into this calculation