fixes: blockfrost chain history transactions limit per address & balance token info #1565
+133
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vetalcore
previously approved these changes
Jan 22, 2025
mkazlauskas
force-pushed
the
fix/blockfrost-chain-history-slice
branch
from
14bb3c2 to
2b9d915
Compare
vetalcore
previously approved these changes
Jan 22, 2025
przemyslaw-wlodek
previously approved these changes
Jan 22, 2025
…of transactions BlockfrostChainHistoryProvider used to incorrectly slice all-address transactions array. This commit changes the behavior to apply the limit per address in order to not miss any transactions. The more addresses you have, the higher the limit.
mkazlauskas
dismissed stale reviews from przemyslaw-wlodek and vetalcore
via
e555950
mkazlauskas
force-pushed
the
fix/blockfrost-chain-history-slice
branch
from
2b9d915 to
e555950
Compare
mkazlauskas
changed the title
We have recently updated BaseWallet to operate with partial tx history. AssetsTracker is fetching AssetInfo only for assets found in tx history. Therefore it wouldn't fetch asset info for assets currently in balance.
mkazlauskas
force-pushed
the
fix/blockfrost-chain-history-slice
branch
from
e49a4ea to
b3c871f
Compare
rhyslbw
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Proposed Solution
Important Changes Introduced