fix(wallet): await for wallet settle before resolving cip30 utxo LW-12197 #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkazlauskas
changed the title
there was a race condition that made cip30 transaction chaining flaky:
- we see a new block, we fetch transactions
- we see transaction on chain and we do the following in parallel:
- we fetch utxos
- we remove transaction from inFlight$
- spent utxo becomes 'available' again for a brief period,
until utxos are fetched
if getUtxos is called after wallet sees transaction on chain,
but before utxos are fetched from provider, it would resolve spent utxo
mkazlauskas
force-pushed
the
fix/settle-before-resolving-cip30-utxo
branch
from
cf60bf6 to
c478116
Compare
rhyslbw
approved these changes
Jan 31, 2025
mirceahasegan
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
there was a race condition that made cip30 transaction chaining flaky:
if getUtxos is called after wallet sees transaction on chain,
but before utxos are fetched from provider, it would resolve spent utxo
Proposed Solution
await for wallet to settle before resolving utxo
Important Changes Introduced