feat: [lw-12170] await for libsodium(Crypto) ready in wallet manager #1582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pczeglik-iohk
approved these changes
Feb 4, 2025
Contributor
pczeglik-iohk
left a comment
pczeglik-iohk
left a comment
There was a problem hiding this comment.
Code looks good @vetalcore
mirceahasegan
approved these changes
Feb 4, 2025
Collaborator
mirceahasegan
left a comment
mirceahasegan
left a comment
There was a problem hiding this comment.
Considering that wallet dependencies are using the Crypto package, I think this is a good place to add this one-time check. 💪
vetalcore
deleted the
fix/lw-12170-await-libsodium-ready-in-wallet-manager-init
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Since this commit most of the Crypto related utils are now sync.
Proposed Solution
But we still need to await for libsodium lib readiness before we can use all the utils.
Current change fixes an error thrown from derivePublic util from Bip32KeyDeriviation.ts, that is triggered (not directly) by wallet manager.
Important Changes Introduced