feat(rust/signed-doc): Add chain field metadata validation rule
#573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apskhem
added
the
squad: gatekeepers
|
✅ Test Report | |
Mr-Leshiy
reviewed
Oct 10, 2025
Mr-Leshiy
requested changes
Oct 14, 2025
Mr-Leshiy
requested changes
Oct 16, 2025
| } | ||
| } | ||
|
|
||
| if doc.report().is_problematic() { |
There was a problem hiding this comment.
No no no, we cannot rely on the CatalystSignedDoc internal report status as a success of this validation rule or not, because it could be the case that some other validation rule wasn't successful and so this one become returning false automatically, even if its ok.
| // chain doc must not be negative | ||
| if chained_height < 0 { | ||
| doc.report().functional_validation( | ||
| "The height of the document being chained to must not be negative", |
There was a problem hiding this comment.
Suggested change
| "The height of the document being chained to must not be negative", | |
| "The height of the document being chained to must be positive number", |
| } | ||
|
|
||
| // have parameters match. | ||
| if chained_doc.doc_meta().parameters() != doc.doc_meta().parameters() { |
There was a problem hiding this comment.
Let's move this validation logic as a part of the parameters validation rule. Look how used and performed link_check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks for contributing to the project!
Please fill out this template to help us review your changes.
Related Issue(s)
Closes #539
Please confirm the following checks