ci: Update lint script and fix warning in smoke test (#1236)

* Update lint script to not tolerate warnings during linter runs * Fix warning in smoke test
input-output-hk · Jun 25, 2024 · 806edbb · 806edbb
1 parent 31c5ee8
commit 806edbb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/...xtension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/WalletAccounts.tsx b/...xtension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/WalletAccounts.tsx
@@ -134,12 +134,15 @@ export const WalletAccounts = ({ isPopup, onBack }: { isPopup: boolean; onBack:
     [disableAccountConfirmation, accountsData]
   );
 
-  const showHWErrorState = useCallback((accountIndex: number) => {
-    enableAccountHWSigningDialog.setData({
-      accountIndex,
-      state: 'error'
-    });
-  }, []);
+  const showHWErrorState = useCallback(
+    (accountIndex: number) => {
+      enableAccountHWSigningDialog.setData({
+        accountIndex,
+        state: 'error'
+      });
+    },
+    [enableAccountHWSigningDialog]
+  );
 
   const unlockHWAccount = useCallback(
     async (accountIndex: number) => {

diff --git a/package.json b/package.json
@@ -29,7 +29,7 @@
     "cleanup": "yarn workspaces foreach run cleanup && yarn exec rm -rf node_modules storybook-static && rm -rf .cache/eslintcache",
     "common:lint": "yarn eslint-cmd \"packages/common/**/*.{js,ts,tsx}\"",
     "core:lint": "yarn eslint-cmd \"packages/core/**/*.{js,ts,tsx}\"",
-    "eslint-cmd": "eslint --cache --cache-location .cache/eslintcache --cache-strategy metadata --ignore-path ./.eslintignore",
+    "eslint-cmd": "eslint --cache --cache-location .cache/eslintcache --cache-strategy metadata --ignore-path ./.eslintignore --max-warnings=0",
     "extension:lint": "yarn eslint-cmd \"apps/browser-extension-wallet/**/*.{js,ts,tsx}\"",
     "format-check": "yarn workspaces foreach -ptv run format-check",
     "postinstall": "husky install & ts-patch install -s",
@@ -48,7 +48,7 @@
   },
   "lint-staged": {
     "*(apps/**/*.{js,ts,tsx}|packages/!(ui|translation)/**/*.{js,ts,tsx}|stories/**/*.{js,ts,tsx})": [
-      "eslint --cache --cache-location .cache/eslintcache --cache-strategy metadata --fix --ignore-path ./.eslintignore",
+      "eslint --cache --cache-location .cache/eslintcache --cache-strategy metadata --fix --ignore-path ./.eslintignore --max-warnings=0",
       "prettier --write"
     ],
     "*(packages/ui/**/*.{js,ts,tsx})": [