Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(extension): load historical tx on demand when scrolling [LW-12099] #1656

Merged
merged 7 commits into from
Feb 13, 2025
Merged

feat(extension): load historical tx on demand when scrolling [LW-12099] #1656

merged 7 commits into from
Feb 13, 2025

Conversation

przemyslaw-wlodek
Copy link
Contributor

@przemyslaw-wlodek przemyslaw-wlodek commented Jan 20, 2025 •
edited by vetalcore
Loading

Checklist

Proposed solution

  • update SDK packages
  • utilise infinite scroll lazy loading

Testing

  • activities list in the activity tab (popup and browser view), please consider next scenarios
    • no initial txs are available
    • pending/signed tx should always appear at the top of the list
    • pending tx should change it status to "confirmed"
    • particular amount of initial txs are available with no more items to load
    • particular amount of initial txs are available with more items to load
    • initially available tx should be displayed almost immediately with no additional requests to blockfrost
  • activities list in the reward history section in the staking page.

@przemyslaw-wlodek przemyslaw-wlodek self-assigned this Jan 20, 2025
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Jan 20, 2025 •
edited
Loading

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 5d450ee8

passed failed skipped flaky total result
Total 33 0 4 0 37 ✅

@przemyslaw-wlodek przemyslaw-wlodek force-pushed the feat/limit-number-of-historical-tx-loaded branch from 0297f2d to 12f26c5 Compare January 21, 2025 08:40
@przemyslaw-wlodek przemyslaw-wlodek changed the title Feat/limit number of historical tx loaded feat(extension): load historical tx on demand when scrolling [LW-12099] Jan 21, 2025
@przemyslaw-wlodek przemyslaw-wlodek force-pushed the feat/limit-number-of-historical-tx-loaded branch 2 times, most recently from 2f748f4 to fabd258 Compare January 21, 2025 08:56
@przemyslaw-wlodek przemyslaw-wlodek marked this pull request as ready for review January 21, 2025 08:57
@przemyslaw-wlodek przemyslaw-wlodek requested a review from a team as a code owner January 21, 2025 08:57
@przemyslaw-wlodek przemyslaw-wlodek force-pushed the feat/limit-number-of-historical-tx-loaded branch from fabd258 to e7d8657 Compare January 21, 2025 11:49
@przemyslaw-wlodek przemyslaw-wlodek force-pushed the feat/limit-number-of-historical-tx-loaded branch from 0b36022 to 27e3221 Compare January 21, 2025 18:47
@przemyslaw-wlodek przemyslaw-wlodek force-pushed the feat/limit-number-of-historical-tx-loaded branch from e98bab4 to a42307e Compare January 22, 2025 19:39
@vetalcore vetalcore requested a review from mkazlauskas January 22, 2025 19:56
@przemyslaw-wlodek przemyslaw-wlodek force-pushed the feat/limit-number-of-historical-tx-loaded branch from fbb8e6b to 9c57765 Compare January 27, 2025 16:53
@vetalcore vetalcore force-pushed the feat/limit-number-of-historical-tx-loaded branch 3 times, most recently from 8403fda to 5a8ca3b Compare January 31, 2025 18:02
@vetalcore vetalcore force-pushed the feat/limit-number-of-historical-tx-loaded branch 4 times, most recently from 77cdce4 to a02a84b Compare February 4, 2025 13:53
@vetalcore vetalcore force-pushed the feat/limit-number-of-historical-tx-loaded branch 2 times, most recently from 06823be to af45ff7 Compare February 6, 2025 13:37
@vetalcore vetalcore mentioned this pull request Feb 6, 2025
Merged
3 tasks
@vetalcore vetalcore force-pushed the feat/limit-number-of-historical-tx-loaded branch from 45628c2 to 944b88a Compare February 12, 2025 20:44
@vetalcore vetalcore force-pushed the feat/limit-number-of-historical-tx-loaded branch from 944b88a to 08af5ac Compare February 13, 2025 09:46
@vetalcore vetalcore enabled auto-merge (squash) February 13, 2025 09:49
przemyslaw-wlodek and others added 6 commits February 13, 2025 12:55
@przemyslaw-wlodek @mkazlauskas
@vetalcore @ljagiela
feat(all): load historical tx on demand when scrolling
1365bcf 
Co-authored-by: Martynas Kazlauskas <[email protected]>
Co-authored-by: vetalcore <[email protected]>
Co-authored-by: Lukasz Jagiela <[email protected]>
@vetalcore
fix: remove history tx limit in the activities slice
a4672c4
@vetalcore
feat: paginate paginated txs in case there are more than page * page …
a2454f2 
…size
@mkazlauskas @vetalcore
fix: do not skip any transactions when loading more
750301c 
if user has multiple addresses, and one of the addresses has a large
gap between transctions, it would skip some transactions

this fix is very inefficient, because it drops and re-fetches txes
it might be acceptable when combined with persistent cache
@mirceahasegan @vetalcore
fix(cardano): fetch from first block on load more after initial load
28f9293 
SDK fetches initial load. First load more should
also load fetch the first block, to not
miss transactions that were sliced.
Subsequent load more calls also fetch all tx from last block.
@vetalcore
fix: [lw-12099] properly filter rewards
7d67d4e
@vetalcore vetalcore force-pushed the feat/limit-number-of-historical-tx-loaded branch from 08af5ac to a086fed Compare February 13, 2025 10:56
@vetalcore vetalcore force-pushed the feat/limit-number-of-historical-tx-loaded branch from a086fed to dfa998e Compare February 13, 2025 11:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vetalcore vetalcore merged commit 86fc244 into main Feb 13, 2025
32 of 33 checks passed
@vetalcore vetalcore deleted the feat/limit-number-of-historical-tx-loaded branch February 13, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vetalcore vetalcore vetalcore approved these changes

@mkazlauskas mkazlauskas mkazlauskas approved these changes

Assignees

@vetalcore vetalcore

@przemyslaw-wlodek przemyslaw-wlodek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@przemyslaw-wlodek @pczeglik-iohk @mkazlauskas @vetalcore @mirceahasegan