fix: [lw-12231] governance placeholder tab #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/browser-extension-wallet/src/assets/images/register-drep-bg.png
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/features/voting-beta/components/Voting.tsx
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/views/browser-view/components/SideMenu/side-menu-config.ts
Outdated
Show resolved
Hide resolved
...views/browser-view/features/voting-beta/components/VotingCenterBanner/VotingCenterBanner.tsx
Outdated
Show resolved
Hide resolved
...ser-extension-wallet/src/views/browser-view/features/voting-beta/components/VotingLayout.tsx
Outdated
Show resolved
Hide resolved
...ser-extension-wallet/src/views/browser-view/features/voting-beta/components/VotingLayout.tsx
Outdated
Show resolved
Hide resolved
greatertomi
requested changes
Feb 11, 2025
apps/browser-extension-wallet/src/features/voting-beta/components/Voting.tsx
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/assets/images/register-drep-bg.png
Outdated
Show resolved
Hide resolved
apps/browser-extension-wallet/src/assets/images/register-drep-bg-popup.png
Outdated
Show resolved
Hide resolved
...views/browser-view/features/voting-beta/components/VotingCenterBanner/VotingCenterBanner.tsx
Show resolved
Hide resolved
...ser-extension-wallet/src/views/browser-view/features/voting-beta/components/VotingLayout.tsx
Outdated
Show resolved
Hide resolved
przemyslaw-wlodek
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
LGTM, thanks @vetalcore! Please make sure to clarify the rest with @greatertomi + answer https://github.com/input-output-hk/lace/pull/1704/files#r1951196126 before merging 😄
greatertomi
approved these changes
Feb 12, 2025
…nce-placeholder-tab
…nce-placeholder-tab
…nce-placeholder-tab
…nce-placeholder-tab
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Popup
Browser View
