Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: connectivity-related issues [LW 12346] #1743

Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix: connectivity-related issues [LW 12346] #1743

merged 2 commits into from
Feb 27, 2025

Conversation

szymonmaslowski
Copy link
Contributor

@szymonmaslowski szymonmaslowski commented Feb 25, 2025 •
edited
Loading

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

  • added Error Boundary component that:
    • catches react rendering errors that would otherwise unmount (crash) entire app
    • logs caught error
    • removes #preloader html element
  • preventing logging sentry connectivity errors to avoid loop of failed requests

Testing

  1. ensure sentry console error logging is enabled by specifying correct environment (link)
  2. set SENTRY_DSN env variable
  3. build
  4. open lace and disable network
  5. click through lace - it should not trigger an infinite number of requests
  6. go to activity - it should show a crash screen

Screenshots

Attach screenshots here if implementation involves some UI changes

@szymonmaslowski szymonmaslowski force-pushed the fix/LW-12346-skip-loggin-sentry-connectivity-error branch from 24983cd to 1e81448 Compare February 25, 2025 11:43
@szymonmaslowski szymonmaslowski changed the title fix: skip logging sentry connectivity error, add [LW 12346] fix: skip logging sentry connectivity error, add error boundary component [LW 12346] Feb 25, 2025
@szymonmaslowski szymonmaslowski changed the title fix: skip logging sentry connectivity error, add error boundary component [LW 12346] fix: connectivity-related issues [LW 12346] Feb 25, 2025
@szymonmaslowski szymonmaslowski self-assigned this Feb 25, 2025
@szymonmaslowski szymonmaslowski marked this pull request as ready for review February 25, 2025 12:29
@szymonmaslowski szymonmaslowski requested a review from a team as a code owner February 25, 2025 12:29
@szymonmaslowski szymonmaslowski force-pushed the fix/LW-12346-skip-loggin-sentry-connectivity-error branch from 1e81448 to 6a5b04a Compare February 25, 2025 13:00
vetalcore
vetalcore approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@vetalcore vetalcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@szymonmaslowski szymonmaslowski force-pushed the fix/LW-12346-skip-loggin-sentry-connectivity-error branch from 6a5b04a to 065378c Compare February 25, 2025 22:55
@szymonmaslowski szymonmaslowski force-pushed the fix/LW-12346-skip-loggin-sentry-connectivity-error branch from 065378c to 0bfdd96 Compare February 27, 2025 12:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@szymonmaslowski szymonmaslowski merged commit f5127ea into main Feb 27, 2025
31 checks passed
@szymonmaslowski szymonmaslowski deleted the fix/LW-12346-skip-loggin-sentry-connectivity-error branch February 27, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vetalcore vetalcore vetalcore approved these changes

@przemyslaw-wlodek przemyslaw-wlodek przemyslaw-wlodek approved these changes

Assignees

@szymonmaslowski szymonmaslowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szymonmaslowski @vetalcore @przemyslaw-wlodek