Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a unique name for the cloud location of digests artifacts Cardano database #2314

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Feb 14, 2025

Content

Fix the naming of the Cloud storage digests location in the artifacts of the Incremental Cardano DB.
The new format name is: <NETWORK>-e<EPOCH>-i<IMMUTABLE_FILE_NUMBER>.digests.json
Example: mainnet-e5-i456.digests.json"

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2306

Copy link

Test Results

    4 files  ±0     56 suites  ±0   10m 49s ⏱️ -3s
1 598 tests +1  1 598 ✅ +1  0 💤 ±0  0 ❌ ±0 
1 902 runs  +1  1 902 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 9ca6713. ± Comparison against base commit 2b0ef17.

@sfauvel sfauvel temporarily deployed to testing-sanchonet February 14, 2025 11:10 — with GitHub Actions Inactive
@sfauvel sfauvel marked this pull request as ready for review February 14, 2025 13:58
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Digests file for Incremental Cardano DB is not updated on the cloud location
3 participants