Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cheatsheet to README #204

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Add cheatsheet to README #204

merged 6 commits into from
Mar 7, 2024

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Mar 7, 2024

Closes #203

@edelarua edelarua added the sme label Mar 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              166      25  84.94%   158-161, 164-167, 206-210, 377-380, 384-387, 420-423
TOTAL                      314      40  87.26%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: fe1d956

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

Unit Tests Summary

 1 files   4 suites   5s ⏱️
34 tests 27 ✅  7 💤 0 ❌
86 runs  75 ✅ 11 💤 0 ❌

Results for commit fe1d956.

♻️ This comment has been updated with latest results.

shajoezhu
shajoezhu reviewed Mar 7, 2024
View reviewed changes
shajoezhu
shajoezhu approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @edelarua , with one minor comment with the check link

@edelarua edelarua merged commit d7ab8ae into main Mar 7, 2024
24 checks passed
@edelarua edelarua deleted the 203_cs_to_readme@main branch March 7, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

@pawelru pawelru pawelru left review comments

@Melkiades Melkiades Awaiting requested review from Melkiades Melkiades is a code owner

@ayogasekaram ayogasekaram Awaiting requested review from ayogasekaram ayogasekaram is a code owner

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cheatsheet to README
3 participants
@edelarua @shajoezhu @pawelru