Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

336 nearest value round #246

Merged
merged 12 commits into from
Feb 28, 2025
Merged

336 nearest value round #246

merged 12 commits into from
Feb 28, 2025

Conversation

gmbecker
Copy link
Collaborator

@gmbecker gmbecker commented Feb 4, 2025

now with a new name, same great taste

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Tests Summary

  1 files    5 suites   10s ⏱️
 44 tests  34 ✅ 10 💤 0 ❌
134 runs  118 ✅ 16 💤 0 ❌

Results for commit 028dd35.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
print 👶 $+0.19$ sas_rounding_support

Results for commit a11620c

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 20, 2025

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  --------------------------------------------
R/paginate_listing.R        29       0  100.00%
R/rlistings_methods.R      129      17  86.82%   38-39, 41, 70, 86, 90, 183-186, 189, 273-279
R/rlistings.R              214      21  90.19%   191-198, 426-429, 433-436, 465-468, 528
TOTAL                      372      38  89.78%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/rlistings_methods.R       +1     -20  +15.73%
R/rlistings.R               +6       0  +0.28%
TOTAL                       +7     -20  +5.68%

Results for commit: 028dd35

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@shajoezhu shajoezhu added the sme label Feb 21, 2025
@shajoezhu shajoezhu self-assigned this Feb 21, 2025
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gmbecker , thanks for the changes, it all look well, can you update the news please?

Signed-off-by: Davide Garolini <[email protected]>
@Melkiades Melkiades enabled auto-merge (squash) February 28, 2025 08:46
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Gabe!!!

@Melkiades Melkiades merged commit 96c883f into main Feb 28, 2025
26 checks passed
@Melkiades Melkiades deleted the 336_nearest_value_round branch February 28, 2025 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants