Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lookup-refs #249

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Remove lookup-refs #249

merged 1 commit into from
Feb 21, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Feb 21, 2025

Part of https://github.com/insightsengineering/coredev-tasks/issues/609

From now on, we will provide development dependencies in

Remotes: repo/project@branch

format, so it's explicitly visible in the DESCRIPTION file and can be handled by pak::install, renv::install and remotes::install.

With development dependencies specified in CJ Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine.

Copy link
Contributor


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Contributor

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------
R/paginate_listing.R        29       0  100.00%
R/rlistings_methods.R      128      37  71.09%   17-39, 59, 75, 79, 165-168, 171, 255-261
R/rlistings.R              194      14  92.78%   180, 396-399, 403-406, 435-438, 498
TOTAL                      351      51  85.47%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/rlistings_methods.R      +11     +11  -6.68%
TOTAL                      +11     +11  -2.77%

Results for commit: e759945

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   5 suites   10s ⏱️
 42 tests 31 ✅ 11 💤 0 ❌
112 runs  96 ✅ 16 💤 0 ❌

Results for commit e759945.

Copy link
Contributor

Unit Tests Summary

  1 files    5 suites   11s ⏱️
 42 tests  42 ✅ 0 💤 0 ❌
126 runs  126 ✅ 0 💤 0 ❌

Results for commit e759945.

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @m7pr

@m7pr m7pr merged commit 2012fd2 into main Feb 21, 2025
25 of 26 checks passed
@m7pr m7pr deleted the remove_lookups branch February 21, 2025 10:18
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@llrs-roche llrs-roche self-assigned this Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants