Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter sort_cols to sort listings #250

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Add parameter sort_cols to sort listings #250

merged 3 commits into from
Feb 28, 2025

Conversation

edelarua
Copy link
Contributor

Closes #248

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Unit Tests Summary

  1 files    5 suites   11s ⏱️
 43 tests  43 ✅ 0 💤 0 ❌
141 runs  141 ✅ 0 💤 0 ❌

Results for commit 51e798d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
listings 👶 $+0.07$ as_listing_sort_cols_works

Results for commit 94f0afd

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------
R/paginate_listing.R        29       0  100.00%
R/rlistings_methods.R      128      37  71.09%   17-39, 59, 75, 79, 165-168, 171, 255-261
R/rlistings.R              208      21  89.90%   191-198, 415-418, 422-425, 454-457, 517
TOTAL                      365      58  84.11%

Diff against main

Filename         Stmts    Miss  Cover
-------------  -------  ------  -------
R/rlistings.R      +14      +7  -2.88%
TOTAL              +14      +7  -1.36%

Results for commit: 51e798d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @edelarua

@edelarua edelarua merged commit e76d2ba into main Feb 28, 2025
28 checks passed
@edelarua edelarua deleted the 248_listing_sort branch February 28, 2025 00:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sorting not by key columns
3 participants