Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Bibcheck: added regexp_replace rules to rules.cfg #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cleggm1
Copy link
Contributor

@cleggm1 cleggm1 commented Dec 20, 2017

Added 12 rules to normalize 65017a in HEPNames using regexp_replace.

Added 12 rules to normalize 65017a in HEPNames using regexp_replace.
@ghost ghost assigned cleggm1 Dec 20, 2017
@ghost ghost added the in progress label Dec 20, 2017
@tsgit
Copy link
Contributor

tsgit commented Dec 21, 2017

@michamos any comment on this?

seems ok, if inefficient, to me

@tsgit tsgit self-requested a review December 21, 2017 16:48
@tsgit
Copy link
Contributor

tsgit commented Dec 22, 2017

/opt/cds-invenio/var/log/bibsched/116/bibsched_task_1161260.log
changed 4805 records to physics.acc-ph
/opt/cds-invenio/var/log/bibsched/116/bibsched_task_1161266.log
changed 377 records to physics.atom-ph
/opt/cds-invenio/var/log/bibsched/116/bibsched_task_1161268.log
changed 120 records to nlin.CD
/opt/cds-invenio/var/log/bibsched/116/bibsched_task_1161269.log
changed 307 records to physics.med-ph
/opt/cds-invenio/var/log/bibsched/116/bibsched_task_1161273.log
changed 73 records to physics.ao-ph
/opt/cds-invenio/var/log/bibsched/116/bibsched_task_1161272.log
changed 217 records to physics.plasma-ph
/opt/cds-invenio/var/log/bibsched/116/bibsched_task_1161271.log
changed 112 records to nucl-ex
/opt/cds-invenio/var/log/bibsched/116/bibsched_task_1161270.log
changed 80 records to nucl-ex
/opt/cds-invenio/var/log/bibsched/116/bibsched_task_1161280.log
changed 537 records to physics.comp-ph

@tsgit
Copy link
Contributor

tsgit commented Dec 22, 2017

the commit message is not very informative
Bibcheck: added regexp_replace rules to rules.cfg
better would be:
BibCheck: rules to normalize HepNames subjects
for display in short log. Also, subtitles or further explanation should be indented 4 chars and started with a * for each bullet point or paragraph

@michamos
Copy link
Contributor

michamos commented Jan 8, 2018

Those that correspond to renamings on arXiv, e.g. chao-dyn -> nlin.CD are already handled in dojson, but it doesn't hurt to convert them on legacy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants