Security: Missing bounds checks on batch size can cause memory/CPU exhaustion#1468
Open
tuanaiseo wants to merge 1 commit into
Conversation
Multiple handlers derive `input_len = len(inputs)` (or vision inputs) and allocate response lists directly from that size without limits. Large crafted requests can trigger oversized allocations and excessive compute, causing denial of service. Affected files: model.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multiple handlers derive
input_len = len(inputs)(or vision inputs) and allocate response lists directly from that size without limits. Large crafted requests can trigger oversized allocations and excessive compute, causing denial of service.Severity:
mediumFile:
integration-test/models/dummy-chat/model.pySolution
Validate and cap maximum batch size before processing (e.g., reject or truncate requests above a configured threshold) and add global request size limits.
Changes
integration-test/models/dummy-chat/model.py(modified)Testing
Note
Low Risk
Low risk: adds a simple bounds check that rejects oversized chat batches before allocating per-item response structures. Main impact is a new
ValueErrorfor requests over the limit, which could affect any callers relying on unbounded batch sizes.Overview
Adds a maximum batch size guard to
integration-test/models/dummy-chat/model.pyby introducingMAX_BATCH_SIZE = 128and rejecting requests wherelen(inputs)exceeds this limit.This prevents oversized batch requests from triggering large list allocations and excessive compute; oversized requests now fail fast with a
ValueError.Reviewed by Cursor Bugbot for commit a616489. Bugbot is set up for automated code reviews on this repo. Configure here.