-
Notifications
You must be signed in to change notification settings - Fork 77
releasenote.md: cleanup and fixes (on top of microcode-20250211) #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
esyr-rh
wants to merge
16
commits into
intel:main
Choose a base branch
from
esyr-rh:microcode-20250211-releasenote-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
38e1f92
releasenote.md: cleanup eliminated usage of U+0080
esyr-rh 9ba332e
releasenote.md: remove excess "Release Notes" headers
esyr-rh feb9a3a
releasenote.md: sort the entries of the 20230808 release lexicographi…
esyr-rh 58160d8
releasenote.md: fix incorrect platform mask for RPL-H/P/U
esyr-rh 008c8fb
releasenote.md: fix stepping for RPL-S
esyr-rh a050fef
releasenote.md: add missing 06-ba-03/e0 to the new microcode section
esyr-rh 680d511
releasenote.md: remove the duplicating 06-9e-0c/22 record
esyr-rh 98f13ea
releasenote.md: fix old revisions for 06-8e-09/10 and 06-55-04/b7 ent…
esyr-rh 15fe2b7
releasenote.md: add old revisions for 06-be-00/11, 06-ba-02/e0, and 0…
esyr-rh 5d7da21
releasenote.md: eliminate trailing white space
esyr-rh 4c72d50
releasenote.md; add information about updates and removals of SPR-SP …
esyr-rh 2b535c8
releasenote.md: add information about 06-ba-08 microcode file
esyr-rh 01fcfaa
releasenote.md: fix whitespace in microcode-20240531 release notes
esyr-rh 1504477
releasenote.md: use "None" for the empty list of new platforms
esyr-rh 2257715
releasenote.md: add missing old revision in microcode-20230512 releas…
esyr-rh 1b64eec
releasenote.md: use new lines consistently
esyr-rh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first release that can be applied to the new processors added by the changed pf_mask.
IMHO, either the old revision field should be blank if the rest of the line only applies to the new processor (that got added to the pf_mask), or the old revision field should have a (*) or footnote, stating that it is the first version for pf 0x when the line is also for processors previously supported by the pf_mask.
THIS COMMENT APPLIES TO PATCH "releasenote.md: fix old revisions for 06-be-00/11, 06-ba-02/e0, and 06-ba-03/e0", ONLY. Ugh, this is the last time I bother reviewing anything using github comments. I apologize for the many edits on this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, as mentioned in the commit message, it is assumed that the part "the old revision field should be blank if the rest of the line only applies to the new processor" is covered by the entries in the "New Platforms" sub-section, but you are right that it is impossible to figure out what was the change in the pf_mask; I was wary of adding any asterisks inside the table, as I'm not sure whether the release notes are supposed to be machine-readable (I only use them for diffing with the generated release notes), but such a concern is probably superfluous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this amendment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM