🎨 Preserve ct_format string types
#183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbeno
force-pushed
the
cts-preserve-constexpr
branch
from
d7d1c07 to
9c0e4df
Compare
Problem: - `ct_format` produces a type that is either a `ct_string` or a `format_result`, which means all client code needs to check that. - `ct_format` works at compile-time but produces a string value that may lose its `constexpr` nature, so can't be put into a type. Solution: - Always return a `format_result` (possibly with an empty tuple). - Wrap the returned `ct_string` in a type.
Problem: - `CX_VALUE` is fine, but sometimes you have a compile-time value that is perfectly fine as a template argument, and you just want to wrap it in a type. Solution: - `ct` provides a way to do that.
elbeno
force-pushed
the
cts-preserve-constexpr
branch
from
9c0e4df to
54c14bd
Compare
Problem: - `CX_VALUE` is fine, but sometimes you have a `std::integral_constant` already. Solution: - Add compile-time formatting support for such values wrapped in types.
elbeno
force-pushed
the
cts-preserve-constexpr
branch
from
54c14bd to
1180eb1
Compare
lukevalenty
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
ct_formatproduces a type that is either act_stringor aformat_result, which means all client code needs to check that.ct_formatworks at compile-time but produces a string value that may lose itsconstexprnature, so can't be put into a type.Solution:
format_result(possibly with an empty tuple).ct_stringin a type.