✨ Add transform_reduce on bitset
#190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbeno
force-pushed
the
bitset-transform-reduce
branch
from
610b361 to
61c1980
Compare
Problem:
- It is relatively common to want to do for_each on a bitset, but also capture
whether or not the action succeeded at all, e.g. when handling a message with
an indexed handler.
Solution:
- Add `transform_reduce` on bitset.
Note:
- Both `for_each` and `transform_reduce` are applicable variadically, however
this is not yet implemented. But this is the reason that the bitset is the
final argument.
- There are some differences (for the better) from the `std::transform_reduce`
API.
- The transform function comes before the reduction function.
`std::transform_reduce` is confusing, because the transform happens first
but is given second.
- The type of the `init` value can be easily given in a template argument;
this is helpful for avoiding warnings when passing `0` (an `int`) to
accumulate potentially larger integral types.
elbeno
force-pushed
the
bitset-transform-reduce
branch
from
61c1980 to
7fc489b
Compare
lukevalenty
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
transform_reduceon bitset.Note:
for_eachandtransform_reduceare applicable variadically, however this is not yet implemented. But this is the reason that the bitset is the final argument.std::transform_reduceAPI.std::transform_reduceis confusing, because the transform happens first but is given second.initvalue can be easily given in a template argument; this is helpful for avoiding warnings when passing0(anint) to accumulate potentially larger integral types.