✨ Add easy way to select optional implementation #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevalenty
approved these changes
May 29, 2025
Contributor
lukevalenty
left a comment
lukevalenty
left a comment
There was a problem hiding this comment.
looks good as long as the unit tests are passing
Problem: - Sometimes it's desirable to select `stdx::optional` or `std::optional` based on whether tombstone_traits is specialized or not. Solution: - Add a `specialized` typedef to the primary template for tombstone_traits to allow easy identification.
elbeno
force-pushed
the
easy-optional-selection
branch
from
d49bfc8 to
50c5fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
stdx::optionalorstd::optionalbased on whether tombstone_traits is specialized or not.Solution:
specializedtypedef to the primary template for tombstone_traits to allow easy identification.