Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add invalid file test for package-lock.json files #3932

Open
terriko opened this issue Mar 13, 2024 · 7 comments · May be fixed by #4787 or #4918
Open

test: add invalid file test for package-lock.json files #3932

terriko opened this issue Mar 13, 2024 · 7 comments · May be fixed by #4787 or #4918
Assignees
@AstikSharma
Labels
good first issue Good for newcomers

Comments

@terriko
Copy link
Contributor

terriko commented Mar 13, 2024

In #3745, @imsahil007 added support for npm package-lock.json files, but since he added support for the type of file I'd been using for an invalid test, we need a new test for that:

  1. We probably should still have some sort of invalid file test. Obviously the npm one we had won't work and you were correct to remove it, but maybe test it against something else that will show up as malformed?

Originally posted by @terriko in #3745 (review)

This is probably a beginner-friendly issue.
@terriko terriko added the good first issue Good for newcomers label Mar 13, 2024
@mvp-2003
Copy link
Contributor

HI @terriko. Can I please take up this issue? This would help me prepare for my GSoC and it might also be a fruitful contribution other than just adding docstrings.

@terriko
Copy link
Contributor Author

terriko commented Mar 18, 2024

@mvp-2003 have fun! Let us know if you get stuck or have questions. Probably you just need to make an empty or intentionally invalid file with the expected name and try to load it for the test. You might want to look at the code that was removed in #3745 if you need an example.

@mvp-2003
Copy link
Contributor

@terriko . looks like I am unable to finish this work. I apologize for the inconvenience. I lack knowledge and skills to work with this one. But thanks for giving me a chance. I'm sorry I couldn't be of much help.

@AstikSharma
Copy link

Hi @terriko ,
I would like to work on this

@terriko
Copy link
Contributor Author

terriko commented Apr 15, 2024

@AstikSharma have fun and let us know if you have any questions!

@asimchoudhary asimchoudhary linked a pull request Feb 8, 2025 that will close this issue
Open
@ThisangaD
Copy link

Hi, I’m Thisanga, a beginner in open source. I’d love to work on this issue! Can you assign me?

@terriko
Copy link
Contributor Author

terriko commented Mar 7, 2025

@ThisangaD I believe we've already got a pull request that may fix this one, so please find another issue to work on. We've got lots, though!

@hai1337 hai1337 linked a pull request Mar 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AstikSharma AstikSharma

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@terriko @mvp-2003 @AstikSharma @ThisangaD