Skip to content

Add test : for invalid package-lock.json file #4787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

asimchoudhary
Copy link

fixes : #3932

Add test for invalid package-lock.json handling

Changes

  • Added empty package-lock-invalid.json file to test invalid npm package format
  • Added test_invalid_package_lock_json test method to verify scanner correctly handles invalid files
  • Scanner should return no products when given an invalid file

@asimchoudhary asimchoudhary changed the title Add test Add test : for invalid package-lock.json file Feb 8, 2025
@terriko
Copy link
Contributor

terriko commented Feb 10, 2025

I've kicked off the tests to run and I'll be back once they're passing. You're going to fail the gitlint one because of the commit message/title of the PR but I can fix that one during merge if it's the only one not passing.

@hai1337
Copy link
Contributor

hai1337 commented Feb 27, 2025

Hey @asimchoudhary - are you planning on addressing the linting failures?

@asimchoudhary
Copy link
Author

hii @hai1337 , currently i am having exams and i think beside the linting errors , the long tests are also failing which might take time to fix.

@hai1337
Copy link
Contributor

hai1337 commented Mar 2, 2025

hii @hai1337 , currently i am having exams and i think beside the linting errors , the long tests are also failing which might take time to fix.

If it is okay with you @asimchoudhary, I would like to work on this issue. If I end up using code that you wrote in your commits, I will add you as a co-author. Let me know if that is okay and good luck with your exams!

@asimchoudhary
Copy link
Author

Yeah sure @hai1337 , if you need the code I wrote u can absolutely use it 😀

@stvml
Copy link
Contributor

stvml commented Apr 7, 2025

@asimchoudhary Hope your exams went well. 😊 I merged the other PR solving this issue since it was ready to go, but thanks for giving it a look!

@stvml stvml closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: add invalid file test for package-lock.json files
4 participants