Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Version Compare To PyPI #4798

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Prtm2110
Copy link
Contributor

@Prtm2110 Prtm2110 commented Feb 11, 2025

Fixes: #4081

Inside cve-bin-tool/cve_bin_tool
run python setup.py sdist bdist_wheel to build the wheel
pip install -e . To check if the package is working as intended
To upload twine upload dist/*

(cev311) xoein@xoeinXD:~/Desktop/CVE-PSF/cve-bin-tool/cve_bin_tool$ python3 
Python 3.11.11 (main, Dec 11 2024, 16:28:39) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from version_compare import version_compare
>>> version_compare("1.2","1.1")
1

Please let me know if you want to change the API or package name and suggestions on LICENSE and README as well.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably need to do a bit of testing and double-check what package names are available in pypi before this can be merged, but I've got a couple of immediate changes to recommend first.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the version compare readme into the main docs table of contents so it gets built and added to our readthedocs site? It's in docs/index.rst or something like that.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Prtm2110
Copy link
Contributor Author

Can you also add the version compare readme into the main docs table of contents so it gets built and added to our readthedocs site? It's in docs/index.rst or something like that.

Sure, I have ref the same README.md fille from compare_parser package. To make it uniform and easy to maintain, let me know what package name on PyPI we are keeping. I will make changes accordingly.

@Prtm2110
Copy link
Contributor Author

Prtm2110 commented Mar 6, 2025

Have you decided on the name package? Are there any other changes you’d like me to make?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release version compare code as separate library on pypi?
2 participants