-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Version Compare To PyPI #4798
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably need to do a bit of testing and double-check what package names are available in pypi before this can be merged, but I've got a couple of immediate changes to recommend first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add the version compare readme into the main docs table of contents so it gets built and added to our readthedocs site? It's in docs/index.rst or something like that.
Sure, I have ref the same README.md fille from compare_parser package. To make it uniform and easy to maintain, let me know what package name on PyPI we are keeping. I will make changes accordingly. |
Have you decided on the name package? Are there any other changes you’d like me to make? |
Fixes: #4081
Inside
cve-bin-tool/cve_bin_tool
run
python setup.py sdist bdist_wheel
to build the wheelpip install -e .
To check if the package is working as intendedTo upload
twine upload dist/*
Please let me know if you want to change the API or package name and suggestions on LICENSE and README as well.