Skip to content

gpu: change 'none' allocation policy #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented May 2, 2023

With shared-dev-num and multiple i915s in the resource request, try to find as many individual GPUs to expose to the container.

Previously, with multiple i915 resources, it was typical to get only one GPU device in the container.

Fixes: #1377

@tkatila tkatila requested review from bart0sh and uniemimu as code owners May 2, 2023 06:20
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #1398 (e20257f) into main (0bf4cd0) will increase coverage by 0.25%.
The diff coverage is 100.00%.

❗ Current head e20257f differs from pull request most recent head db7cd12. Consider uploading reports for the commit db7cd12 to get more accurate results

@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
+ Coverage   50.89%   51.14%   +0.25%     
==========================================
  Files          44       44              
  Lines        4985     5005      +20     
==========================================
+ Hits         2537     2560      +23     
+ Misses       2302     2300       -2     
+ Partials      146      145       -1     
Impacted Files Coverage Δ
cmd/gpu_plugin/gpu_plugin.go 88.28% <100.00%> (+1.06%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tkatila tkatila force-pushed the gpu-none-policy-update branch from 4112b04 to badd48e Compare May 2, 2023 11:14
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only trivial comments...

With shared-dev-num and multiple i915s in the resource request,
try to find as many individual GPUs to expose to the container.

Previously, with multiple i915 resources, it was typical to
get only one GPU device in the container.

Co-authored-by: Eero Tamminen <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
@tkatila tkatila force-pushed the gpu-none-policy-update branch from 9fa7d54 to db7cd12 Compare May 3, 2023 06:26
@uniemimu
Copy link
Contributor

uniemimu commented May 3, 2023

@uniemimu uniemimu merged commit 4e645d8 into intel:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Claiming i915 resources in a single container has 2 cards accessible for Intel GPU Flex 140
4 participants