Skip to content

Add cpu/memory requests and limits #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add cpu/memory requests and limits #1819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions deployments/dlb_plugin/base/intel-dlb-plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ spec:
readOnlyRootFilesystem: true
allowPrivilegeEscalation: false
terminationMessagePath: /tmp/termination-log
resources:
requests:
memory: "15Mi"
cpu: 40m
limits:
memory: "30Mi"
cpu: 100m
volumeMounts:
- name: devfs
mountPath: /dev
Expand Down
7 changes: 7 additions & 0 deletions deployments/dsa_plugin/base/intel-dsa-plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ spec:
type: "container_device_plugin_t"
readOnlyRootFilesystem: true
allowPrivilegeEscalation: false
resources:
requests:
memory: "25Mi"
cpu: 50m
limits:
memory: "50Mi"
cpu: 100m
volumeMounts:
- name: devfs
mountPath: /dev/dsa
Expand Down
7 changes: 7 additions & 0 deletions deployments/fpga_plugin/base/intel-fpga-plugin-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ spec:
securityContext:
readOnlyRootFilesystem: true
allowPrivilegeEscalation: false
resources:
requests:
memory: "30Mi"
cpu: 80m
limits:
memory: "60Mi"
cpu: 160m
volumeMounts:
- name: devfs
mountPath: /dev
Expand Down
7 changes: 7 additions & 0 deletions deployments/gpu_plugin/base/intel-gpu-plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ spec:
type: "container_device_plugin_t"
readOnlyRootFilesystem: true
allowPrivilegeEscalation: false
resources:
requests:
memory: "45Mi"
cpu: 40m
limits:
memory: "90Mi"
cpu: 100m
volumeMounts:
- name: devfs
mountPath: /dev/dri
Expand Down
7 changes: 7 additions & 0 deletions deployments/iaa_plugin/base/intel-iaa-plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ spec:
type: "container_device_plugin_t"
readOnlyRootFilesystem: true
allowPrivilegeEscalation: false
resources:
requests:
memory: "25Mi"
cpu: 60m
limits:
memory: "50Mi"
cpu: 120m
volumeMounts:
- name: devfs
mountPath: /dev/iax
Expand Down
7 changes: 7 additions & 0 deletions deployments/qat_plugin/base/intel-qat-plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ spec:
readOnlyRootFilesystem: true
allowPrivilegeEscalation: false
imagePullPolicy: IfNotPresent
resources:
requests:
memory: "15Mi"
cpu: 70m
limits:
memory: "30Mi"
cpu: 140m
volumeMounts:
- name: devdir
mountPath: /dev/vfio
Expand Down
7 changes: 7 additions & 0 deletions deployments/sgx_plugin/base/intel-sgx-plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ spec:
readOnlyRootFilesystem: true
allowPrivilegeEscalation: false
imagePullPolicy: IfNotPresent
resources:
requests:
memory: "15Mi"
cpu: 40m
limits:
memory: "30Mi"
cpu: 100m
volumeMounts:
- name: kubeletsockets
mountPath: /var/lib/kubelet/device-plugins
Expand Down
11 changes: 11 additions & 0 deletions pkg/controllers/dlb/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (

apps "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/diff"
"k8s.io/apimachinery/pkg/util/intstr"
Expand Down Expand Up @@ -92,6 +93,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
ReadOnlyRootFilesystem: &yes,
AllowPrivilegeEscalation: &no,
},
Resources: v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("100m"),
v1.ResourceMemory: resource.MustParse("30Mi"),
},
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("40m"),
v1.ResourceMemory: resource.MustParse("15Mi"),
},
},
VolumeMounts: []v1.VolumeMount{
{
Name: "devfs",
Expand Down
11 changes: 11 additions & 0 deletions pkg/controllers/dsa/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (

apps "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/diff"
"k8s.io/apimachinery/pkg/util/intstr"
Expand Down Expand Up @@ -96,6 +97,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
ReadOnlyRootFilesystem: &yes,
AllowPrivilegeEscalation: &no,
},
Resources: v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("100m"),
v1.ResourceMemory: resource.MustParse("50Mi"),
},
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("50m"),
v1.ResourceMemory: resource.MustParse("25Mi"),
},
},
VolumeMounts: []v1.VolumeMount{
{
Name: "devfs",
Expand Down
11 changes: 11 additions & 0 deletions pkg/controllers/fpga/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (

apps "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/diff"
"k8s.io/apimachinery/pkg/util/intstr"
Expand Down Expand Up @@ -94,6 +95,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
AllowPrivilegeEscalation: &no,
},
TerminationMessagePath: "/tmp/termination-log",
Resources: v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("160m"),
v1.ResourceMemory: resource.MustParse("60Mi"),
},
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("80m"),
v1.ResourceMemory: resource.MustParse("30Mi"),
},
},
VolumeMounts: []v1.VolumeMount{
{
MountPath: "/dev",
Expand Down
11 changes: 11 additions & 0 deletions pkg/controllers/gpu/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (

apps "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/diff"
"k8s.io/apimachinery/pkg/util/intstr"
Expand Down Expand Up @@ -106,6 +107,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
ReadOnlyRootFilesystem: &yes,
AllowPrivilegeEscalation: &no,
},
Resources: v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("100m"),
v1.ResourceMemory: resource.MustParse("90Mi"),
},
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("40m"),
v1.ResourceMemory: resource.MustParse("45Mi"),
},
},
VolumeMounts: []v1.VolumeMount{
{
Name: "devfs",
Expand Down
11 changes: 11 additions & 0 deletions pkg/controllers/iaa/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (

apps "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/diff"
"k8s.io/apimachinery/pkg/util/intstr"
Expand Down Expand Up @@ -96,6 +97,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
ReadOnlyRootFilesystem: &yes,
AllowPrivilegeEscalation: &no,
},
Resources: v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("120m"),
v1.ResourceMemory: resource.MustParse("50Mi"),
},
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("60m"),
v1.ResourceMemory: resource.MustParse("25Mi"),
},
},
VolumeMounts: []v1.VolumeMount{
{
Name: "devfs",
Expand Down
11 changes: 11 additions & 0 deletions pkg/controllers/qat/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (

apps "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/diff"
"k8s.io/apimachinery/pkg/util/intstr"
Expand Down Expand Up @@ -100,6 +101,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
ReadOnlyRootFilesystem: &yes,
AllowPrivilegeEscalation: &no,
},
Resources: v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("140m"),
v1.ResourceMemory: resource.MustParse("30Mi"),
},
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("70m"),
v1.ResourceMemory: resource.MustParse("15Mi"),
},
},
VolumeMounts: []v1.VolumeMount{
{
Name: "devdir",
Expand Down
11 changes: 11 additions & 0 deletions pkg/controllers/sgx/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (

apps "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/diff"
"k8s.io/apimachinery/pkg/util/intstr"
Expand Down Expand Up @@ -88,6 +89,16 @@ func (c *controller) newDaemonSetExpected(rawObj client.Object) *apps.DaemonSet
ReadOnlyRootFilesystem: &yes,
AllowPrivilegeEscalation: &no,
},
Resources: v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("100m"),
v1.ResourceMemory: resource.MustParse("30Mi"),
},
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("40m"),
v1.ResourceMemory: resource.MustParse("15Mi"),
},
},
VolumeMounts: []v1.VolumeMount{
{
Name: "kubeletsockets",
Expand Down
Loading