add quant_state to state_dict#805
Closed
yuchengliu1 wants to merge 1 commit intointel:mainfrom
yuchengliu1:IPB-2934
Closed
add quant_state to state_dict#805yuchengliu1 wants to merge 1 commit intointel:mainfrom yuchengliu1:IPB-2934
yuchengliu1 wants to merge 1 commit intointel:mainfrom
yuchengliu1:IPB-2934
Conversation
Contributor
|
I don't know if it's a robust fix because |
Contributor
Author
|
We need modify the static_dict according to the wrapper of parameter. So we recursively find the parameter from model by the key of original static_dict. BNB hook the recursive process when generating the static_dict. The different of recursive process between IPEX and BNB cause the failure. |
Contributor
|
As we discussed offline. The BNB rewrite the _save_to_state_dict func so the quant_state parameter can be accessed. IPEX need same modification to read quant_state parameter. |
jiqing-feng
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the failure happened when the module's name mismatches the state dict keys if a layer rewrites the _save_to_state_dict function.