Added type fix in the docstrings of PagedAttention#875
Open
AdityaKulshrestha wants to merge 2 commits intointel:mainfrom
Open
Added type fix in the docstrings of PagedAttention#875AdityaKulshrestha wants to merge 2 commits intointel:mainfrom
AdityaKulshrestha wants to merge 2 commits intointel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
I have added fix for I guess an older method name in the docstring of PagedAttention. It has been using
flash_atten_varlen, I have updated it toflash_attn_varlen_func.The parameters for enabling causal masking is referred as
is_cusal. I am not sure if it was also done on purpose or just a typo since there are multiple instances of the same.Thanks!