Skip to content

Commit ee969fb

Browse files
sys-igcigcbot
authored andcommitted
[Autobackout][FunctionalRegression]Revert of change: aaf6e45: Turn on EnableUniformSimd1Stores pass for CS
Turn on EnableUniformSimd1Stores to use SIMD1 for uniform SLM Stores
1 parent 41499bc commit ee969fb

File tree

4 files changed

+1
-9
lines changed

4 files changed

+1
-9
lines changed

IGC/Compiler/CISACodeGen/DriverInfo.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,6 @@ namespace IGC
383383
virtual bool supportLscSamplerRouting() const { return true; }
384384
virtual bool supportBarrierControlFlowOptimization() const { return false; }
385385
virtual bool getLscStoresWithNonDefaultL1CacheControls() const { return true; }
386-
virtual bool supportMergeUniformSimd1Stores() const { return true; }
387386

388387
// Informs if the UMD understands atomic pull tile walk for raytracing
389388
virtual bool supportsAtomicPullSWTileWalk() const { return false; }

IGC/Compiler/CISACodeGen/Platform.hpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1930,10 +1930,5 @@ bool allowsMoviForType(VISA_Type type) const {
19301930
return (type == ISA_TYPE_UD || type == ISA_TYPE_D);
19311931
}
19321932

1933-
bool supportMergeUniformSimd1Stores() const
1934-
{
1935-
return isCoreChildOf(IGFX_XE2_HPG_CORE);
1936-
}
1937-
19381933
};
19391934
}//namespace IGC

IGC/Compiler/CISACodeGen/ShaderCodeGen.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1920,8 +1920,6 @@ void OptimizeIR(CodeGenContext* const pContext)
19201920
}
19211921

19221922
if (pContext->type == ShaderType::COMPUTE_SHADER &&
1923-
pContext->m_DriverInfo.supportMergeUniformSimd1Stores() &&
1924-
pContext->platform.supportMergeUniformSimd1Stores() &&
19251923
IGC_IS_FLAG_ENABLED(EnableUniformSimd1Stores))
19261924
{
19271925
mpm.add(new MergeUniformStores());

IGC/common/igc_flags.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ DECLARE_IGC_REGKEY(DWORD, FPRoundingModeCoalescingMaxDistance, 20, "Max distance
341341
DECLARE_IGC_REGKEY(bool, DisableDotAddToDp4aMerge, false, "Disable Dot and Add ops to Dp4a merge optimization.", false)
342342
DECLARE_IGC_REGKEY(bool, DisableLoopSplitWidePHIs, false, "Disable splitting of loop PHI values to eliminate subvector extract operations", false)
343343
DECLARE_IGC_REGKEY(bool, EnableBarrierControlFlowOptimizationPass, false, "Enable barrier control flow optimization pass", false)
344-
DECLARE_IGC_REGKEY(bool, EnableUniformSimd1Stores, true, "Collapse SIMD32 uniform stores into SIMD1 to reduce pressure", true)
344+
DECLARE_IGC_REGKEY(bool, EnableUniformSimd1Stores, false, "Collapse SIMD32 uniform stores into SIMD1 to reduce pressure", true)
345345
DECLARE_IGC_REGKEY(bool, EnableWaveShuffleIndexSinking, true, "Hoist identical instructions operating on WaveShuffleIndex instructions with the same source and a constant lane/channel", false)
346346
DECLARE_IGC_REGKEY(DWORD, WaveShuffleIndexSinkingMaxIterations, 3, "Max number of iterations to run iterative WaveShuffleIndexSinking", false)
347347
DECLARE_IGC_REGKEY(bool, EnableWaveAllJointReduction, false, "Enable Joint Reduction Optimization.", false)

0 commit comments

Comments
 (0)