KVM: add low_mem_nxhp and high_mem_nxhp testcase#563
KVM: add low_mem_nxhp and high_mem_nxhp testcase#563atlarator wants to merge 2 commits intointel:mainfrom
Conversation
|
It seems that the merging for boot.py and boot_hugepage.py is ok. |
| if params.get("reboot_method"): | ||
| hugepage_config = None | ||
| try: | ||
| _update_dynamic_params(test, params) |
There was a problem hiding this comment.
Should have a check before calling it directly.
There was a problem hiding this comment.
Only the 2 new adding tests need this function call, right?
| if params.get_boolean("manual_hugepage_setup"): | ||
| hugepage_config = _setup_manual_hugepages(params) | ||
|
|
||
| vm_name = params["main_vm"] |
There was a problem hiding this comment.
boot.py is used by boot_vm_in_hugepage.cfg and multi_vms.cfg, did you test both of their cases?
There was a problem hiding this comment.
It seems that when testcases in these two fields run separately (like only hugepage or only multi_vm) should have no problem, but when mixed, like running both hugepage and multi_vm testcases in one run, the hugepage cases will fail, the way to fix this is kill the qemu process manually.
|
@fanchen2 Can you help to review this tests? |
2 participants
OK, this seems like a breaking change, it firstly changes the default testing script for 2M hugepage and 1G hugepage to
test/boot_hugepage.py, some default configuration are changed due to create failure of virtual machines due to memory alignment issue.Please review this pull request carefully as part of this commit is modify by chatgpt-codex-5.4 built in github copilot.
for testcases, lgtm.